bugphpGroupWare - Bugs: bug #3373, Bad relations between phpgw_log...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #3373: Bad relations between phpgw_log and phpgw_accounts

Submitted by:  Kai Hofmann <powerstat>
Submitted on:  Tue 29 Apr 2003 09:04:58 AM UTC  
 
Item Group: SVN trunk (dev code)Category: API - Admin
Severity: 3 - NormalPriority: 5 - Normal
Status: InvalidPrivacy: Public
Assigned to: Dave Hall <skwashd>Open/Closed: Closed
Component Version: SVNOperating System: None
Reproducibility: Every TimePlanned Release: None
Fixed Release: 

Wed 21 Apr 2004 08:09:29 AM UTC, comment #2:

The code mentioned in the report is no longer in the 16 branch. It should be fixed up in the merge2HEAD.

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Wed 21 Apr 2004 07:41:28 AM UTC, comment #1:

Kai, make a suggestion how to improve it ...

Dr. Christian Böttger <cboettger>
Tue 29 Apr 2003 09:04:58 AM UTC, original submission:

Within the admin module there are two different relations between phpgw_log and phpgw_accounts.
An if statement decides between the two variants.
This is absolutly evil! - only one column should be used for relations between tables!

$parms['where'] = array('phpgw_log.log_user = phpgw_accounts.account_id');
$parms['where'][] = 'phpgw_log.log_id = phpgw_accounts.account_id';
./admin/inc/class.solog.inc.php

Kai Hofmann <powerstat>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 21 Apr 2004 08:09:29 AM UTCskwashdStatusNone=>Invalid
  Open/ClosedOpen=>Closed
Wed 21 Apr 2004 07:41:28 AM UTCcboettgerAssigned toNone=>skwashd
Tue 20 Jan 2004 11:52:47 AM UTCpowerstatAssigned toInvalid User ID=>None
Tue 29 Apr 2003 10:39:17 PM UTCskwashdAssigned toNone=>NA
  Component VersionNone=>(Error - Not Found)
  ReproducibilityNone=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1