bugCompact Disc Input and Control Library - Bugs: bug #33636, path names in toc / cue

 
 

bug #33636: path names in toc / cue

Submitted by:  None
Submitted on:  Fri 24 Jun 2011 11:51:06 AM UTC  
 
Category: NoneSeverity: 5 - Average
Item Group: libcdioStatus: None
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Originator Email: -unavailable-Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 29 Dec 2011 07:28:19 PM UTC, comment #3:

Works on Gentoo 32bit!

Leon Merten Lohse <greenleon>
Project Member
Sun 25 Dec 2011 08:44:59 PM UTC, comment #2:

A little while ago I added some code to address this. Please check if this code does what you want on OS's that use / as a path separator.

Thanks.

There are hooks for the / versus \ convention of Windows but since the usual compilation is on cygwin there hasn't been a need for it yet. (Possibly if done via mingw or a mingw cross compilation we'll need it, but I'll cross that bridge when it is needed.)

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Mon 27 Jun 2011 07:34:51 AM UTC, comment #1:

I'll try to get to this before the next release. If you want to suggest a patch that might speed things along.

Although there might not be a portable function in say the POSIX library, various interpreters like Python or Ruby provide such a function. In Ruby it is called File.expand_path and I think the MRI implementation codes this in C.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Fri 24 Jun 2011 11:51:06 AM UTC, original submission:

Relative path names in toc and cue files are meant to be relative to the toc or cue file.

libcdio reads these pathnames verbatim, resulting in them being used relative to the current working directory.

The `cd-info TOC test CD-DA' from check_cue.sh fails because of that. The BINCUE test does not fail but that is because the path to the bin file is not used in the test.

Where to fix:
lib/driver/image/cdrdao.c:662
lib/driver/image/cdrdaoc.:731
lib/driver/image/bincue.c:334

How to fix:
append filename from cue/toc to the pathname of cue or toc.

Problem:
there is no portable pathname function.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by greenleon (Posted a comment)
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by greenleon
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 18 Mar 2012 05:41:49 PM UTCrockyOpen/ClosedOpen=>Closed
    Mon 27 Jun 2011 07:34:51 AM UTCrockyAssigned toNone=>rocky
    Fri 24 Jun 2011 02:58:20 PM UTCgreenleonCarbon-Copy-=>Added greenleon

    Back to the top


    Powered by Savane 3.1-cleanup1