bugGNU GRUB - Bugs: bug #33426, possible null pointer dereference...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #33426: possible null pointer dereference in ohci.c

Submitted by:  David Volgyes <dvolgyes>
Submitted on:  Sun 29 May 2011 08:50:59 AM UTC  
 
Category: NoneSeverity: Major
Priority: 5 - NormalItem Group: Software Error
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: ClosedRelease: 
Release: Bazaar - trunkReproducibility: None
Planned Release: None

Thu 23 Jun 2011 06:31:16 PM UTC, comment #1:

Applied. Thanks. Next time please use universal diff and add a Changelog entry.

Vladimir Serbinenko <phcoder>
Project Administrator
Sun 29 May 2011 08:50:59 AM UTC, original submission:

There is a check in the code, but I think the condition must cover all the following lines not just the first one:

Original:
if (o)
grub_dma_free (o->td_chunk);
grub_dma_free (o->ed_bulk_chunk);
grub_dma_free (o->ed_ctrl_chunk);
grub_dma_free (o->hcca_chunk);
grub_free (o);

My version:
if (o)
{
grub_dma_free (o->td_chunk);
grub_dma_free (o->ed_bulk_chunk);
grub_dma_free (o->ed_ctrl_chunk);
grub_dma_free (o->hcca_chunk);
grub_free (o);
}

Patch is submitted.

(Bug was found by cppcheck 1.47.)

David Volgyes <dvolgyes>

 

Attached Files
file #23465:  ohci.patch added by dvolgyes (665B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by dvolgyes (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 23 Jun 2011 06:31:16 PM UTCphcoderStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 29 May 2011 08:50:59 AM UTCdvolgyesAttached File-=>Added ohci.patch, #23465

    Back to the top


    Powered by Savane 3.1-cleanup1