bugGNU GRUB - Bugs: bug #33424, resource leak & redundant...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #33424: resource leak & redundant cehck in emu/hotdisk.c

Submitted by:  David Volgyes <dvolgyes>
Submitted on:  Sun 29 May 2011 08:39:31 AM UTC  
 
Category: NoneSeverity: Major
Priority: 5 - NormalItem Group: Software Error
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: ClosedRelease: 
Release: Bazaar - trunkReproducibility: Every Time
Planned Release: None

Thu 23 Jun 2011 08:05:14 PM UTC, comment #1:

Second part fixed. First part isn't of any real trouble.

Vladimir Serbinenko <phcoder>
Project Administrator
Sun 29 May 2011 08:39:31 AM UTC, original submission:

Cppcheck found two bugs in hotdisk.c, both of them are real bugs.

[grub-1.99~rc2/grub-core/kern/emu/hostdisk.c:674]: (error) _linux_ is already guaranteed to be defined

#ifdef _linux_
was in a "#ifdef _linux_" section.

[grub-1.99~rc2/grub-core/kern/emu/hostdisk.c:1773]: (error) Resource leak: fd

fd was not closed before "return".

Patch is submitted.

David Volgyes <dvolgyes>

 

Attached Files
file #23463:  hotdisk.patch added by dvolgyes (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by dvolgyes (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 23 Jun 2011 08:05:14 PM UTCphcoderStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 29 May 2011 08:39:31 AM UTCdvolgyesAttached File-=>Added hotdisk.patch, #23463

    Back to the top


    Powered by Savane 3.1-cleanup1