bugCompact Disc Input and Control Library - Bugs: bug #33333, cdda-player should not wrap the...

 
 

bug #33333: cdda-player should not wrap the volume adjustment

Submitted by:  Christopher Yeleighton <yecril71pl>
Submitted on:  Tue 17 May 2011 06:03:25 PM UTC  
 
Category: feature requestSeverity: 5 - Average
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 20 May 2011 09:39:17 PM UTC, comment #14:

AC_LANG_SOURCE thing from comment #12 applied in git. However in the future please attach patches as a file. Cutting and pasting from the comment didn't work for me, so it's possible things are a little different.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Fri 20 May 2011 09:15:01 PM UTC, comment #13:

The player works as expected. Thanks.

Christopher Yeleighton <yecril71pl>
Fri 20 May 2011 09:05:03 PM UTC, comment #12:

configure.ac:456: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...

diff --git a/configure.ac b/configure.ac
index 71d967a..2a4f7fa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -453,7 +453,7 @@ esac
AC_SUBST(LT_NO_UNDEFINED)

AC_MSG_CHECKING(extern long timezone variable)
-AC_LINK_IFELSE([
+AC_LINK_IFELSE([AC_LANG_SOURCE([[
#ifdef NEED_TIMEZONEVAR
#define timezonevar 1
#endif
@@ -464,6 +464,7 @@ int main(int argc, char **argv) {
-AC_LINK_IFELSE([
+AC_LINK_IFELSE([AC_LANG_SOURCE([[
#ifdef NEED_TIMEZONEVAR
#define timezonevar 1
#endif
@@ -464,6 +464,7 @@ int main(int argc, char **argv) {
long test_timezone = timezone;
return 0;
}
+]])
], [AC_MSG_RESULT(yes);
AC_DEFINE([HAVE_TIMEZONE_VAR], 1,
[Define if you have an extern long timenzone variable.])],

Christopher Yeleighton <yecril71pl>
Thu 19 May 2011 11:55:57 AM UTC, comment #11:

Should be fixed in git. Run git pull and try again.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Thu 19 May 2011 09:36:32 AM UTC, comment #10:

I installed libtool but make failed.

make all-recursive
make[1]: Wejście do katalogu `/home/krzysztof/proj/libcdio'
Making all in doc
make[2]: Wejście do katalogu `/home/krzysztof/proj/libcdio/doc'
restore=: && backupdir=".am$$" && \
am__cwd=`pwd` && CDPATH="${ZSH_VERSION+.}:" && cd . && \
rm -rf $backupdir && mkdir $backupdir && \
if (/bin/sh /home/krzysztof/proj/libcdio/missing --run makeinfo --version) >/dev/null 2>&1; then \
for f in libcdio.info libcdio.info-[0-9] libcdio.info-[0-9][0-9] libcdio.i[0-9] libcdio.i[0-9][0-9]; do \
if test -f $f; then mv $f $backupdir; restore=mv; else :; fi; \
done; \
else :; fi && \
cd "$am__cwd"; \
if /bin/sh /home/krzysztof/proj/libcdio/missing --run makeinfo -I . \
-o libcdio.info libcdio.texi; \
then \
rc=0; \
CDPATH="${ZSH_VERSION+.}:" && cd .; \
else \
rc=$?; \
CDPATH="${ZSH_VERSION+.}:" && cd . && \
$restore $backupdir/* `echo "./libcdio.info" | sed 's|[^/]*$||'`; \
fi; \
rm -rf $backupdir; exit $rc
libcdio.texi:4: @include `version.texi': Nie ma takiego pliku ani katalogu.
makeinfo: Usuwanie pliku wyjściowego `libcdio.info' z powodu błędów; --force pozwoli go zachować.
make[2]: *** [libcdio.info] Błąd 1
make[2]: Opuszczenie katalogu `/home/krzysztof/proj/libcdio/doc'
make[1]: *** [all-recursive] Błąd 1
make[1]: Opuszczenie katalogu `/home/krzysztof/proj/libcdio'
make: *** [all] Błąd 2

Christopher Yeleighton <yecril71pl>
Thu 19 May 2011 06:45:16 AM UTC, comment #9:

I have not tried building from git before.
I do not have libtool installed.
I have seen packages bring libtool with them.
The file README.develop does not mention having libtool.

Software you'll need to build a development version libcdio
- git
- autoconf (which contains programs autoconf and autoreconf)
- automake
- m4 (used by autoconf)
- texinfo (for building documentation)
- help2man (turns help for libcdio standalone programs into manual pages)

Christopher Yeleighton <yecril71pl>
Wed 18 May 2011 01:03:41 PM UTC, comment #8:

Works for me.

Had you tried building from git before? You have libtool installed?

<pre>
$ git clone git://git.savannah.gnu.org/libcdio.git
git clone git://git.savannah.gnu.org/libcdio.git
Initialized empty Git repository in /tmp/libcdio/.git/
remote: Counting objects: 17381, done.
remote: Compressing objects: 100% (3593/3593), done.
remote: Total 17381 (delta 13763), reused 17325 (delta 13728)
Receiving objects: 100% (17381/17381), 16.99 MiB | 1.56 MiB/s, done.
Resolving deltas: 100% (13763/13763), done.
$ cd libcdio/
cd libcdio/
08:43:44 rocky@dr-ferdinand:/tmp/libcdio [2,0,b] 0
$ sh ./autogen.sh
Rebuilding ./configure with autoreconf...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./config.guess'
libtoolize: copying file `./config.sub'
libtoolize: copying file `./install-sh'
...
config.status: executing default commands
configure:
Using CD-ROM drivers : cdrdao, BIN/CUE, NRG, GNU/Linux
Building cd-paranoia : yes
Building cd-info : yes
Building cd-read : yes
Building cdda-player : yes
Building iso-info : yes
Building iso-read : yes
Building C++ programs: yes
$
</pre>

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Wed 18 May 2011 09:10:55 AM UTC, comment #7:

autogen.sh did not fly:

configure.ac:268: error: possibly undefined macro: AM_PROG_LIBTOOL
autoreconf: /usr/bin/autoconf failed with exit status: 1
autoreconf failed

Christopher Yeleighton <yecril71pl>
Wed 18 May 2011 08:57:10 AM UTC, comment #6:

Ok. Fixed in git now.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Wed 18 May 2011 08:26:51 AM UTC, comment #5:

And BTW, it is "subtract from", not "subtract to"…

Christopher Yeleighton <yecril71pl>
Wed 18 May 2011 08:24:56 AM UTC, comment #4:

The comment about 0 it mentions 99, it is inaccurate even if taken mutatis mutandis because you can reasonably expect 0 to be the minimum. The real reason here is that suddenly going from 0 to 99 could get you arrested :-)

Christopher Yeleighton <yecril71pl>
Wed 18 May 2011 07:53:14 AM UTC, comment #3:

Ok. This all make a lot of sense. Thanks for reporting the error and taking the time to explain this in a simple way, that even user-interface imbecile can understand.

Changes have been made in the git repository so that we don't wrap around now. Please double check to make sure this matches your expectation.

Thanks.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Wed 18 May 2011 06:48:16 AM UTC, comment #2:

Short: Yes, I do :-)

Long: The current implementation expects that the operator:

* looks at the display while listening,
* knows that 99 is the maximum value.

If either assumption is not satisfied, ??? Profit.

Christopher Yeleighton <yecril71pl>
Wed 18 May 2011 04:17:36 AM UTC, comment #1:

You are probably correct that there should be no wrap around. Currently it wraps around in both directions. So I'll consider this.

However it would be helpful if you could give justification why this behavior is better or the other behavior worse. You have fat fingers and just hold the + key down?

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Tue 17 May 2011 06:03:25 PM UTC, original submission:

cdda-player sets the volume to 0 when requested to play louder at the maximum
volume

Steps to Reproduce:
1. Insert an audio CD.
2. { cdda-player; }
3. Press [+] to set volume to 99.
4. Press [+].

Actual Results:
4. Volume: 0

Expected Results:
4. Volume: 99

Christopher Yeleighton <yecril71pl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by yecril71pl (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 May 2011 07:53:14 AM UTCrockyStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 18 May 2011 04:17:36 AM UTCrockyAssigned toNone=>rocky

    Back to the top


    Powered by Savane 3.1-cleanup1