bugGNU GRUB - Bugs: bug #33150, the testsuite should not hardcode...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #33150: the testsuite should not hardcode path to parted

Submitted by:  Peter Hjalmarsson <xake>
Submitted on:  Sun 24 Apr 2011 09:51:25 AM UTC  
 
Category: NoneSeverity: Major
Priority: 5 - NormalItem Group: Feature Request
Status: FixedPrivacy: Public
Assigned to: Colin Watson <cjwatson>Originator Name: 
Open/Closed: ClosedRelease: 
Release: Bazaar - trunkReproducibility: Every Time
Planned Release: None

Tue 03 May 2011 05:06:28 PM UTC, comment #1:

Thanks. I fixed this differently in trunk; we only use the value of that variable to execute parted, so just 'parted=parted' is sufficient (this is just a convenience variable in case somebody wants to run parted from somewhere else).

2011-05-03 Colin Watson <cjwatson@ubuntu.com>

* tests/partmap_test.in: Don't hardcode path to parted.
Reported by: Peter Hjalmarsson. Fixes Savannah bug #33150.

Colin Watson <cjwatson>
Project MemberIn charge of this item.
Sun 24 Apr 2011 09:51:25 AM UTC, original submission:

Different distributions places parted in different places (for example it it seems like Debian places it in /sbin, while Gentoo by default places it in /usr/sbin).

So I propose the following patch to remove the hardcoded path to parted, and instead check for it at runtime with the help of which.

Peter Hjalmarsson <xake>

 

Attached Files
file #23295:  which-parted.patch added by xake (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cjwatson (Posted a comment)
  • -unavailable- added by xake (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 03 May 2011 05:06:28 PM UTCcjwatsonStatusNone=>Fixed
      Assigned toNone=>cjwatson
      Open/ClosedOpen=>Closed
    Sun 24 Apr 2011 09:51:25 AM UTCxakeAttached File-=>Added which-parted.patch, #23295

    Back to the top


    Powered by Savane 3.1-cleanup1