bugGNU Octave - Bugs: bug #33063, Feature Request : Add the colstyle...

 
 

bug #33063: Feature Request : Add the colstyle function

Submitted by:  David Bateman <dbateman>
Submitted on:  Wed 13 Apr 2011 02:41:22 PM UTC  
 
Category: PlottingSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: David Bateman <dbateman>
Originator Name: David BatemanOpen/Closed: Closed
Release: 3.4.0Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 15 Apr 2011 02:04:42 AM UTC, comment #4:

I added the function in this changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/2846ea58b288).

Before committing, I added some input validation to the function as well as some functional tests. In addition I put the help text in the advanced plot section of the manual and added colstyle to the list of new functions in NEWS file.

Rik <rik5>
Project Administrator
Wed 13 Apr 2011 08:09:21 PM UTC, comment #3:

It seems fine to me to add this function for 3.4.1.

John W. Eaton <jwe>
Project Administrator
Wed 13 Apr 2011 07:25:08 PM UTC, comment #2:

Its rather that my dev machine crashed and I can't be bothered recovering my ssh keys, and setting up a new dev machine till I decide what to buy to replace it. I've been using an anonymous checkout of the repository to make changeset and need help to push them from work.

For colstyle pushing to the default branch seems fine, but pushing it to the stable branch would make the people at work I'm helping to port MTEX happy. So I was seeking approval to allow the changeset to be pushed to the stable branch as well.

D.

David Bateman <dbateman>
Project MemberIn charge of this item.
Wed 13 Apr 2011 03:40:44 PM UTC, comment #1:

David, are you no longer comfortable pushing your own patches to the hg repo? Or are you asking for code review?

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Wed 13 Apr 2011 02:41:22 PM UTC, original submission:

While trying to port the MTEX package from

http://code.google.com/p/mtex/

I've been finding quite a few bugs in Octave, and missing features. One of the missing features is the the colstyle function. This was first requested in 2008 in the thread

https://mailman.cae.wisc.edu/pipermail/help-octave/2008-April/029645.html

where I proposed some code. Here is this code as a changeset. Could I get this added for 3.4.1? This would probably allow me to get MTEX to work with 3.4.1 and not have to wait for a 3.6 release. The change shouldn't have any nefarious impacts.

David

David Bateman <dbateman>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23235:  changeset3 added by dbateman (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by dbateman (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Apr 2011 02:04:42 AM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 13 Apr 2011 02:41:22 PM UTCdbatemanAttached File-=>Added changeset3, #23235

    Back to the top


    Powered by Savane 3.1-cleanup1