bugGnash - The GNU Flash player - Bugs: bug #32927, jemalloc.c: Compiler warnings

 
 

bug #32927: jemalloc.c: Compiler warnings

Submitted by:  None
Submitted on:  Sun 27 Mar 2011 03:17:31 PM UTC  
 
Category: buildSeverity: 2 - Minor
Release: masterStatus: Wont Fix
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 29 Mar 2011 05:03:21 PM UTC, comment #7:

I've updated jemalloc to mozilla HEAD. Only one of the warnings was fixed, but all of the warnings from -Wall are still there. There isn't much we can do about that except stop compiling with -Wall for jemalloc.c, seeing as upstream is not likely interested in unused variable warnings, but that's a pain to do using automake. So on the balance, I think this is a wontfix.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Tue 29 Mar 2011 11:01:46 AM UTC, comment #6:

Yes, though I think we'd have to wait until it enters debian stable.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Tue 29 Mar 2011 01:18:09 AM UTC, comment #5:

Our version is based on the Firefox version, so upgrading would be possible, but just copying it over won't work. Our version was tweaked to work with Gnash's config/build infrastructure, plus I added mallinfo() support, which I still use. Merging the newer version in would be nice, I'd like valgrind support too.

Rob Savoye <rsavoye>
Project Administrator
Mon 28 Mar 2011 05:36:19 PM UTC, comment #4:

The following warning:
jemalloc.c:3866:3: warning: cast discards qualifiers from pointer target type

has been fixed upstream (mozilla jemalloc). The other warnings have not, probably because most people don't build with -Wall. It does not seem especially practical to omit that warning for our copy of jemalloc because automake makes that complicated.

In the mean time, it may still be useful to update our jemalloc to mozilla HEAD, to get bugfixes and other improvements, such as Valgrind support.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 27 Mar 2011 04:08:03 PM UTC, comment #3:

No, we can't just updated out copy, as our version has mallinfo() support, and has also been tweaked to builds from within Gnash. Our version is also based on the Firefox version, and not the original FreeBSD version. I doubt these warnings are fixed upstream.

Rob Savoye <rsavoye>
Project Administrator
Sun 27 Mar 2011 04:05:09 PM UTC, comment #2:

I'm sure these warnings are fixed upstream; we could just update our copy of jemalloc.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 27 Mar 2011 03:20:30 PM UTC, comment #1:

Note that the warning vary depending on which platform Gnash is compiled on. As the majority of these are "defined but not used", I've always just ignored them, although it would be possible to eliminate them with sufficient multi-platform testing.

Rob Savoye <rsavoye>
Project Administrator
Sun 27 Mar 2011 03:17:31 PM UTC, original submission:

CC libgnashbase_la-jemalloc.lo
jemalloc.c: In function 'arena_salloc':
jemalloc.c:3866:3: warning: cast discards qualifiers from pointer target type
jemalloc.c: At top level:
jemalloc.c:1285:1: warning: 'malloc_spin_init' defined but not used
jemalloc.c:1676:1: warning: 'base_calloc' defined but not used
jemalloc.c:1857:1: warning: 'extent_tree_szad_s_RB_FIND' defined but not used
jemalloc.c:1857:1: warning: 'extent_tree_szad_s_RB_NEXT' defined but not used
jemalloc.c:1857:1: warning: 'extent_tree_szad_s_RB_PREV' defined but not used
jemalloc.c:1857:1: warning: 'extent_tree_szad_s_RB_MINMAX' defined but not used
jemalloc.c:1869:1: warning: 'extent_tree_ad_s_RB_NEXT' defined but not used
jemalloc.c:2611:1: warning: 'arena_chunk_tree_s_RB_FIND' defined but not used
jemalloc.c:2611:1: warning: 'arena_chunk_tree_s_RB_NFIND' defined but not used
jemalloc.c:2611:1: warning: 'arena_chunk_tree_s_RB_NEXT' defined but not used
jemalloc.c:2626:1: warning: 'arena_run_tree_s_RB_FIND' defined but not used
jemalloc.c:2626:1: warning: 'arena_run_tree_s_RB_NFIND' defined but not used
jemalloc.c:2626:1: warning: 'arena_run_tree_s_RB_NEXT' defined but not used
jemalloc.c:2626:1: warning: 'arena_run_tree_s_RB_PREV' defined but not used

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by rsavoye (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 29 Mar 2011 05:03:21 PM UTCbjacquesStatusNone=>Wont Fix
      Open/ClosedOpen=>Closed
    Tue 29 Mar 2011 11:05:03 AM UTCbjacquesAssigned toNone=>bjacques
    Sun 27 Mar 2011 03:20:30 PM UTCrsavoyeSeverity3 - Normal=>2 - Minor
      ReleaseNone=>master

    Back to the top


    Powered by Savane 3.1-cleanup1