bugGnash - The GNU Flash player - Bugs: bug #32774, Remove --enable-i810-lod-bias...

 
 

bug #32774: Remove --enable-i810-lod-bias configure option

Submitted by:  Andrew Guertin <dolphinling>
Submitted on:  Mon 14 Mar 2011 09:25:25 AM UTC  
 
Category: buildSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Benjamin Wolsey <bwy>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 14 Mar 2011 10:06:34 AM UTC, comment #4:

Done, thanks.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Mon 14 Mar 2011 10:01:49 AM UTC, comment #3:

Andrew Guertin <dolphinling@dolphinling.net>

Andrew Guertin <dolphinling>
Mon 14 Mar 2011 09:57:20 AM UTC, comment #2:

What email address should I use for the commit log?

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Mon 14 Mar 2011 09:33:16 AM UTC, comment #1:

Thanks, will apply after verifying compile and testing.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Mon 14 Mar 2011 09:25:25 AM UTC, original submission:

Quoting from the manual: "Enable fix for Intel 810 LOD bias problem. Older versions of libMesa on the Intel i810 or i815 graphics processor need this flag or Gnash will core dump. This has been fixed in newer versions (summer 2005) of libMesa."

This only affects the ogl renderer, so for someone to need this option, they'd have to be using modern gnash on a ~8 year old computer with >6 year old graphics libraries, and then choosing a less-maintained renderer. I think this is highly unlikely.

The main benefit of removal would be that the option would no longer be there to confuse people or take up screen space in documentation.

I've attached a patch. I've tested that the patch compiles and runs with the opengl renderer. It passes the testsuite with the default renderer, but I didn't find how to run the testsuite with a non-default renderer*. I also have not regenerated the documentation, so that needs to be done.

  • IIRC it would fail some tests anyway due to things not implemented in the opengl renderer, right?
Andrew Guertin <dolphinling>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22921:  remove-i810lodbias.patch added by dolphinling (9KiB - application/octet-stream - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by dolphinling (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 14 Mar 2011 10:06:34 AM UTCbwyStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Mon 14 Mar 2011 09:33:16 AM UTCbwyStatusNone=>In Progress
      Assigned toNone=>bwy
    Mon 14 Mar 2011 09:25:25 AM UTCdolphinlingAttached File-=>Added remove-i810lodbias.patch, #22921

    Back to the top


    Powered by Savane 3.1-cleanup1