bugGnash - The GNU Flash player - Bugs: bug #32506, assertion failure in commonGetURL()

 
 

bug #32506: assertion failure in commonGetURL()

Submitted by:  Bastiaan Jacques <bjacques>
Submitted on:  Wed 16 Feb 2011 09:03:20 PM UTC  
 
Category: coreSeverity: 4 - Important
Release: masterStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 17 Feb 2011 06:20:33 PM UTC, comment #8:

Crash fixed by 78619f0b6b11fcc4af9564f3179703ba12e46533

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 17 Feb 2011 11:12:31 AM UTC, comment #7:

I've tested that path-based should work, so either we fix movie_root::findCharacterByTarget to also recognize path-based or we keep passing trough findTarget(env) for the sake of converting path-based to dot-based addresses.

I'd keep the current behavior, after all the bug is in movie_root being unable to parse _level0.first.second, which has nothing
to do with path-based addresses.

NOTE: the path-based support is tested automatically now with loadMovieTest under misc-ming.all.

That test should be further enhanced to expose this bug.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 17 Feb 2011 09:58:26 AM UTC, comment #6:

For the record, the case is:
DEBUG: get url: target=_level0.richload1.loader, url=http://www.flashtalking.net/Uploads/VAinstantAds/8738/richLoads/USA_BE_SALE_728x90_rich.swf, method=40 (sendVars:0, loadTarget:1, loadVariable:0)

I'm working on enhancing the existing loadMovieTest.c to use that method of loading, so to also use different kind of targets (path-based, dot-based..)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 17 Feb 2011 09:54:11 AM UTC, comment #5:

For info: 0.8.6 doesn't crash.

Benjamin Wolsey <bwy>
Project Member
Thu 17 Feb 2011 09:37:42 AM UTC, comment #4:

Fails in 0.8.7 too.

Benjamin Wolsey <bwy>
Project Member
Thu 17 Feb 2011 09:24:11 AM UTC, comment #3:

Sounds like _level0 in _level0 evaluates to a _level0._level0 object ?!?

movie_root::findCharacterByTarget(_level0.richload1.loader) enter
string part: '_level0', looking in obj '_level0'
string part: 'richload1', looking in obj '_level0._level0'

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 17 Feb 2011 09:22:30 AM UTC, comment #2:

Problem is that findTarget(env, <string>) and movie_root::findCharacterByTarget(<string>) give different results

This has even nothing to do with scope chain as the target <string> is a full path:

findTarget(env,_level0.richload1.loader):0x7f5f7807b620,
movie_root.findCharacterByTarget(_level0.richload1.loader):0

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 17 Feb 2011 09:20:18 AM UTC, comment #1:

Fails in 0.8.8 too.

Benjamin Wolsey <bwy>
Project Member
Wed 16 Feb 2011 09:03:20 PM UTC, original submission:

http://cdn.flashtalking.com/tagsv3/89378/160859/swf/URL_S_WASH_BE_728x90.swf

lt-gtk-gnash: /home/bastiaan/gnash/master/libcore/vm/ASHandlers.cpp:3626: void gnash::{anonymous}::commonGetURL(gnash::as_environment&, gnash::as_value, const string&, uint8_t): Assertion `m.findCharacterByTarget(s) == target_movie' failed.

Bastiaan Jacques <bjacques>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by bjacques (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Mar 2011 07:03:46 PM UTCbwyAssigned toNone=>strk
    Thu 17 Feb 2011 06:20:33 PM UTCstrkStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Thu 17 Feb 2011 09:22:30 AM UTCstrkCategoryNone=>core
      StatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1