Sat 29 Jan 2011 03:06:46 AM UTC, comment #5:
Thanks for the patch. I noticed that problem earlier, just after I committed the set of ARPACK changes and created a patch, but then forgot to push it. It's done now.
I don't think there are duplicated declarations. Note the first arguments of the two that you show are different, one is Matrix and the other SparseMatrix.
|
Sat 29 Jan 2011 01:14:15 AM UTC, comment #3:
The move of the #endif mentioned below produces a build
which runs make check without any errors.
However, I did also notice thar there are quite a few
duplicated declarations. The first example is:
extern octave_idx_type
EigsRealSymmetricMatrix (const Matrix& m, const std::string typ,
octave_idx_type k, octave_idx_type p,
octave_idx_type &info, Matrix &eig_vec,
ColumnVector &eig_val, const Matrix& b,
ColumnVector &permB, ColumnVector &resid,
std::ostream &os, double tol = DBL_EPSILON,
bool rvec = false, bool cholB = 0, int disp = 0,
int maxit = 300);
extern octave_idx_type
EigsRealSymmetricMatrix (const SparseMatrix& m, const std::string typ,
octave_idx_type k, octave_idx_type p,
octave_idx_type &info, Matrix &eig_vec,
ColumnVector &eig_val, const SparseMatrix& b,
ColumnVector &permB, ColumnVector &resid,
std::ostream& os, double tol = DBL_EPSILON,
bool rvec = false, bool cholB = 0, int disp = 0,
int maxit = 300);
===============================================
Similar examples follow this. Is there any reason not to clean this
up?
|