bugtexinfo - GNU documentation system - Bugs: bug #32255, info crashes if # of rows is very...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #32255: info crashes if # of rows is very small

Submitted by:  Hilmar Preusse <hpreusse>
Submitted on:  Wed 26 Jan 2011 03:59:07 PM UTC  
 
Category: infoRelease: 4.13a
Priority: 5 - NormalSeverity: 3 - Normal
Item Group: bugPrivacy: Public
Open/Closed: ClosedAssigned to: None
Status: Fixed

Wed 02 Feb 2011 06:46:17 PM UTC, comment #1:

I installed Ben's patch to avoid the crash on resize-to-small-window. I could reproduce the crash and verify that the patch fixed it. Thanks much.

I couldn't get the "gap" on repeated resizings, BTW, though I don't doubt that it's possible. As stated, the whole window computation code is rather a mess.

Karl Berry <karl>
Project Administrator
Wed 26 Jan 2011 03:59:07 PM UTC, original submission:

We got a bug report down here in the DBTS: http://bugs.debian.org/611151

<snip>
This bug is easy to reproduce. Simply run "info" in a terminal, then resize the terminal to have a height smaller than 6. The info program immediately exits with a segmentation fault.

The problem is that window.c:window_line_of_point() can return a negative index. A simple fix is to sanity check the output (patch
attached).

That patch will prevent segmentation faults, but there is still something wrong with the arithmetic, probably in window_new_screen_size() which is a mess. Shrinking and enlarging the buffer repeatedly leaves a gap, but that's the subject for another bug.
<snip>

The submitter provided a patch, which can be found in the bug report (not tested by me).

Hilmar Preusse <hpreusse>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by karl (Posted a comment)
  • -unavailable- added by karl
  • -unavailable- added by hpreusse (Submitted the item)
  • -unavailable- added by hpreusse
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Feb 2011 06:46:17 PM UTCkarlOpen/ClosedOpen=>Closed
      StatusNone=>Fixed
      Carbon-Copy-=>Added -unavailable-
    Wed 26 Jan 2011 03:59:07 PM UTChpreusseCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1