bugGNUstep - Bugs: bug #32166, dynamic theme switching and...

Group
 
 

bug #32166: dynamic theme switching and in-window menu bar

Submitter:  Riccardo Mottola <rmottola>
Submitted:  Tue 18 Jan 2011 10:56:15 AM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  None
Privacy:  Public Assigned to:  gcasa
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 04 Feb 2011 05:28:18 PM UTC, comment #4: 


> I think you are mixing a few separate issues here.


I don't think I am.  While this bug talks about a very specific issue with theme switching, I'm talking about theme switching as a whole.   When I address this bug, I intend on fixing this issue and any others I can find with switching between themes.

>  The old code used to support changing in either direction, this is no longer true.


I'll assume you're correct here, but this wasn't always my experience.   Switching themes in general has always been a very imperfect process.

> Code to support this needs to go into GSTheme in gui.


Yes, indeed, as I mentioned here...

"What is likely needed is some code in the deactivate method of the GSTheme class to remove the in-window menus from all menus when switching."

I should also mention that there is additional cleanup which needs to be done in GSTheme's deactivate method, such as unloading all of the images from the theme being transitioned from...  probably by reloading the GNUstep default images... since the theme being transitioned to might not redefine all of the images.

> How window managers come into play here is something I don't understand. I am
> not aware of any window manager that cares about in-window menus. Although
> this might be a good idea.


To clarify...   I was simply saying that the previous approach of having the menu switch between windows was not a good solution in the first place.    The reason I'm working on the GNOME theme, in specific, is to blend in better with other platforms.

GC

Gregory John Casamento <gcasa>
Group administrator
Wed 02 Feb 2011 09:23:19 AM UTC, comment #3: 

I think you are mixing a few separate issues here.

First of all the theme switching needs to work with all the GNUstep menu settings. That is horizontal/vertical and in-window/separate window. The old code used to support changing in either direction, this is no longer true. Code to support this needs to go into GSTheme in gui.

Support for the GNOME theme that may use a different technology to implement in-window menus is up tot he GNOME theme. This needs code that handles activation and deactivation correctly. That code doesn't belong into GNUstep gui.

How window managers come into play here is something I don't understand. I am not aware of any window manager that cares about in-window menus. Although this might be a good idea.

Fred Kiefer <FredKiefer>
Group Member
Mon 31 Jan 2011 11:28:29 PM UTC, comment #2: 


>  I suspect that he had good reasons to do so. Probably something in the line
> of that everybody should be using in-window menus and never go back to the
> old way :-)


I don't believe that everyone should be using in-window menus.   Theme switching has always been imperfect, especially regarding in-window menus.

What is likely needed is some code in the deactivate method of the GSTheme class to remove the in-window menus from all menus when switching.   I was too lazy to do this while working on the GNOME theme, but this is a sore spot which needs to be addressed.

I removed the old way of switching between windows because it does not serve the purpose of meshing with any existing environment.  Switching the in-window menus in and out of windows is not implemented by any window manager I am aware of.

GC

Gregory John Casamento <gcasa>
Group administrator
Mon 31 Jan 2011 08:58:57 PM UTC, comment #1: 

This happens because Greg removed the code that would remove the menu view from the window when he changed that code in GSThemeMenu.m. I suspect that he had good reasons to do so. Probably something in the line of that everybody should be using in-window menus and never go back to the old way :-)

Fred Kiefer <FredKiefer>
Group Member
Tue 18 Jan 2011 10:56:15 AM UTC, original submission:  

When switching from a theme which has an in-window menu bar to another wone which has not (e.g. back to the default one) the horizontal menu bar remains even if the standard one is displayed.

Riccardo Mottola <rmottola>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gcasa (Posted a comment)
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by rmottola (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-01 gcasa Open/ClosedOpen Closed
    2011-01-31 FredKiefer Assigned toNone gcasa
    2011-01-18 rmottola Summarydynamich tehme switching and in-window menu bar dynamic theme switching and in-window menu bar

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code