Fri 04 Feb 2011 05:28:18 PM UTC, comment #4:
> I think you are mixing a few separate issues here.
I don't think I am. While this bug talks about a very specific issue with theme switching, I'm talking about theme switching as a whole. When I address this bug, I intend on fixing this issue and any others I can find with switching between themes.
> The old code used to support changing in either direction, this is no longer true.
I'll assume you're correct here, but this wasn't always my experience. Switching themes in general has always been a very imperfect process.
> Code to support this needs to go into GSTheme in gui.
Yes, indeed, as I mentioned here...
"What is likely needed is some code in the deactivate method of the GSTheme class to remove the in-window menus from all menus when switching."
I should also mention that there is additional cleanup which needs to be done in GSTheme's deactivate method, such as unloading all of the images from the theme being transitioned from... probably by reloading the GNUstep default images... since the theme being transitioned to might not redefine all of the images.
> How window managers come into play here is something I don't understand. I am
> not aware of any window manager that cares about in-window menus. Although
> this might be a good idea.
To clarify... I was simply saying that the previous approach of having the menu switch between windows was not a good solution in the first place. The reason I'm working on the GNOME theme, in specific, is to blend in better with other platforms.
GC
|