bugGNUstep - Bugs: bug #31983, GSDragView.m...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #31983: GSDragView.m draggingSourceOperationMaskForLocal:

Submitted by:  Banlu Kemiyatorn <id>
Submitted on:  Sun 26 Dec 2010 09:22:07 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Mon 27 Dec 2010 01:47:02 PM UTC, comment #3:

Looks like Apple changed that from 10.5 to 10.6.

I made a few changes to the class and now all the calls to the dragging source should check whether the method is actually implemented. I also added a call to draggedImage:movedTo:.

All these checks should be cached on the GSDragView as they wont change for the same dragging source.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Mon 27 Dec 2010 12:15:04 PM UTC, comment #2:

I read from

http://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ApplicationKit/Protocols/NSDraggingSource_Protocol/Reference/Reference.html

draggingSourceOperationMaskForLocal:

[..]

Discussion
"If not implemented, the default value is NSDragOperationCopy |
NSDragOperationLink | NSDragOperationGeneric |
NSDragOperationPrivate."

Banlu Kemiyatorn <id>
Mon 27 Dec 2010 11:54:29 AM UTC, comment #1:

Acoording to Apples documentation this is a method that has to be implemented all of the times:

"This method is the only NSDraggingSource method that must be implemented by the source object."

If this statement from the documentation does not match the actual implementation in Cocoa I am willing to change the code otherwise, we better leave it the way it is now.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sun 26 Dec 2010 09:22:07 PM UTC, original submission:

GSDragView.m:649

dragMask = [dragSource draggingSourceOperationMaskForLocal: !destExternal];

should query and if not implemented, return
NSDragOperationLink|NSDragOperationCopy|NSDragOperationGeneric|NSDragOperationPrivate.

Banlu Kemiyatorn <id>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by id (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 03 Oct 2011 08:47:04 PM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Mon 27 Dec 2010 01:47:02 PM UTCFredKieferStatusInvalid=>Ready For Test
      Open/ClosedDeclined=>In Test
    Mon 27 Dec 2010 11:54:29 AM UTCFredKieferStatusNone=>Invalid
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>Declined

    Back to the top


    Powered by Savane 3.1-cleanup1