bugGnash - The GNU Flash player - Bugs: bug #31953, 'make distcheck' fail to find...

 
 

bug #31953: 'make distcheck' fail to find ltdl.h on openbsd

Submitted by:  Petter Reinholdtsen <pere>
Submitted on:  Thu 23 Dec 2010 09:39:47 AM UTC  
 
Category: buildSeverity: 3 - Normal
Release: masterStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 13 Jan 2011 09:53:01 AM UTC, comment #3:

tested by buildbot, it seems..

Sandro Santilli <strk>
Project Member
Wed 29 Dec 2010 04:38:38 AM UTC, comment #2:

This should be fixed as of 399c42b5702bac224c86b51da07f85e6f2685b2d. The problem was when using BSD make and libtool 1.5, the expansion of DIST_SUBDIRS = libltdl was failing to pick up the header file. The fix was to just add them to a EXTRA_DIST instead when using libtool 1.5. Otherwise ltdl.h fails to be in the tarball that make dist makes, which is what distcheck does to start.

Rob Savoye <rsavoye>
Project Administrator
Thu 23 Dec 2010 09:47:02 AM UTC, comment #1:

The -I../../libltdl is there indeed. I'd like to see the content of that directory (maybe something is not being distributed...).

Brad, can you check the contents of gnash-0.8.9dev/libltdl ?

Sandro Santilli <strk>
Project Member
Thu 23 Dec 2010 09:39:47 AM UTC, original submission:

Doing 'make distcheck' fail on openbsd with this error:

Making all in libbase
/bin/sh ../libtool --tag=CC --mode=compile ccache cc -DHAVE_CONFIG_H -I. -I../../libbase -I.. -I../../libltdl -g -O2 -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -MT libltdlc_la-ltdl.lo -MD -MP -MF .deps/libltdlc_la-ltdl.Tpo -c -o libltdlc_la-ltdl.lo `test -f '../../libltdl/ltdl.c' || echo '../../libbase/'`../../libltdl/ltdl.c
mkdir .libs
ccache cc -DHAVE_CONFIG_H -I. -I../../libbase -I.. -I../../libltdl -g -O2 -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -MT libltdlc_la-ltdl.lo -MD -MP -MF .deps/libltdlc_la-ltdl.Tpo -c ../../libltdl/ltdl.c -fPIC -DPIC -o .libs/libltdlc_la-ltdl.o
../../libltdl/ltdl.c:129:18: error: ltdl.h: No such file or directory
../../libltdl/ltdl.c:218: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'LT_PARAMS'
../../libltdl/ltdl.c:219: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lt_emalloc'
../../libltdl/ltdl.c:220: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lt_erealloc'
../../libltdl/ltdl.c:226: error: expected declaration specifiers or '...' before '*' token
[...]

The complete log is available from http://gnashdev.org:8010/builders/4.8-release-openbsd-amd64/builds/65/steps/make_distcheck/logs/stdio .

According to strk on IRC, the fix might be to add -I$(top_srcdir)/libltdl to the LIBLTDL2 block in libbase/Makefile.am. I am not able to test and verify this.

Petter Reinholdtsen <pere>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Updated the item)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by strk
  • -unavailable- added by pere (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 13 Jan 2011 09:53:01 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 29 Dec 2010 04:38:38 AM UTCrsavoyeStatusNeed Info=>Ready For Test
    Thu 23 Dec 2010 09:47:02 AM UTCstrkStatusNone=>Need Info
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1