bugGnash - The GNU Flash player - Bugs: bug #31919, Plugin->Browser javascript...

 
 

bug #31919: Plugin->Browser javascript execution (Externalinterface::call) is broken

Submitted by:  None
Submitted on:  Sat 18 Dec 2010 04:35:09 PM UTC  
 
Category: pluginSeverity: 3 - Normal
Release: trunkStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 19 Dec 2010 08:51:04 PM UTC, comment #5:

You can close this, of course. Thanks

Anonymous
Sun 19 Dec 2010 05:29:09 PM UTC, comment #4:

I'll be starting the next Gnash release process in a few weeks, so at the least it'll get out then. The usual goal being to get the release out before the Fedora and Ubuntu freezes for fc15 and Natty. Packages with this patch will be available on our getgnash.org site for many distributions once the problems with savannah are fixed. So it will be available to people till the release comes out anyway.

I'd think to test this you'd add support to plugin/npapi/scriptable-test.html, which is what I used to develop all the External Interface code. Being a web page, it's a manual only test, but does let you exercise all the functionality.

btw, if this works, can I close the bug ?

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Sun 19 Dec 2010 05:22:11 PM UTC, comment #3:

I've taken a look at plugin/npapi/test.cpp, and it seems to me that a test for this functionality does not fill well with the current architecture.

By the way, could this patch be backported to the stable branch so that it will be picked up by packagers sooner?

Anonymous
Sat 18 Dec 2010 10:28:55 PM UTC, comment #2:

Rob committed this as ec3bc9210945726e5c026afd27e062e253192c7a
Would still be nice to have some automated tests.

Sandro Santilli <strk>
Project Member
Sat 18 Dec 2010 04:49:50 PM UTC, comment #1:

Could you also add a test to plugin/npapi/test.cpp ?

Sandro Santilli <strk>
Project Member
Sat 18 Dec 2010 04:35:09 PM UTC, original submission:

With current git when the plugin receive an invoke request from the gnash application it tries to resolve the method on the gnash object itself instead of the browser window object. Moreover no arguments are passed. The attached patch fixes the behavior.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22225:  0001-Fix-NPN_Invoke-usage-when-executing-Javascript-from-.patch added by None (3KiB - text/x-diff - Proposed patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Updated the item)
  • -unavailable- added by strk (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 19 Dec 2010 08:52:22 PM UTCrsavoyeStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 19 Dec 2010 05:29:09 PM UTCrsavoyeAssigned toNone=>rsavoye
    Sat 18 Dec 2010 10:28:55 PM UTCstrkStatusNone=>Ready For Test
    Sat 18 Dec 2010 04:35:09 PM UTCNoneAttached File-=>Added 0001-Fix-NPN_Invoke-usage-when-executing-Javascript-from-.patch, #22225

    Back to the top


    Powered by Savane 3.1-cleanup1