bugGNU Wget - Bugs: bug #31378, Strange code in retr.c at line 871...

 
 

bug #31378: Strange code in retr.c at line 871 (1.12-2428)

Submitted by:  None
Submitted on:  Tue 19 Oct 2010 11:39:13 PM UTC  
 
Category: Program LogicSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: Giuseppe Scrivano <gscrivano>
Originator Name: Manfred KoizarOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 1.12
Operating System: NoneReproducibility: None
Fixed Release: NonePlanned Release: 1.13
Regression: NoneWork Required: None
Patch Included: No

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 21 Oct 2010 11:30:26 AM UTC, comment #1:

Thanks. I have committed a fix, it is commit #2435.

Giuseppe Scrivano <gscrivano>
Project AdministratorIn charge of this item.
Tue 19 Oct 2010 11:39:13 PM UTC, original submission:

If I read this code snippet correctly it owes its existence to a copy'n'paste error:

First, how can (*dt & RETROKF) be false, when it was true a few lines above?

Second, why should we register download, redirection, and html twice?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gscrivano (Posted a comment)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 21 Oct 2010 11:30:26 AM UTCgscrivanoStatusNone=>Fixed
      Assigned toNone=>gscrivano
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>1.13

    Back to the top


    Powered by Savane 3.1-cleanup1