bugGNU Wget - Bugs: bug #31354, wget does not parse html files...

 
 

bug #31354: wget does not parse html files linked by <link rel="..."

Submitted by:  None
Submitted on:  Sun 17 Oct 2010 02:57:04 AM UTC  
 
Category: Program LogicSeverity: 3 - Normal
Priority: 5 - NormalStatus: Ready for Merge
Privacy: PublicAssigned to: Giuseppe Scrivano <gscrivano>
Originator Name: Manfred KoizarOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 1.12
Operating System: GNU/LinuxReproducibility: Every Time
Fixed Release: NonePlanned Release: None
Regression: NoneWork Required: None
Patch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 17 Oct 2010 10:30:50 PM UTC, comment #1:

Thanks. The patch looks good, I am going to commit it.

Giuseppe Scrivano <gscrivano>
Project AdministratorIn charge of this item.
Sun 17 Oct 2010 02:57:04 AM UTC, original submission:

Due to a misplaced closing brace tag_handle_link() didn't set link_expect_html, unless the rel attribute was missing entirely. The attached patch fixes this.

And I added a few lines to not assume the linked file is html, when a type attribute explicitly says, it's not.

I'm not sure what to do with link tags without any rel attribute. If wget is to treat those links as html somebody has to re-add

else
up->link_expect_html = 1;

at its old position.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21697:  01_link_tag.diff added by None (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gscrivano (Posted a comment)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 17 Oct 2010 10:30:50 PM UTCgscrivanoStatusNone=>Ready for Merge
      Assigned toNone=>gscrivano
      Open/ClosedOpen=>Closed
    Sun 17 Oct 2010 02:57:04 AM UTCNoneAttached File-=>Added 01_link_tag.diff, #21697

    Back to the top


    Powered by Savane 3.1-cleanup1