bugGNU patch - Bugs: bug #31313, --binary and --silent don't work...

 
 

bug #31313: --binary and --silent don't work in conjunction

Submitted by:  Elias Pipping <pipping>
Submitted on:  Tue 12 Oct 2010 01:49:20 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 13 Oct 2010 10:18:56 PM UTC, comment #1:

What a weird bug. Thanks for catching it!

I have fixed this in the git repository and in

patch-2.6.1.102-5b460.tar.gz

on

ftp://alpha.gnu.org/gnu/patch/

> (there is no way to just disable --silent again but not enable
> --verbose, is there?)


No, sorry.

Andreas Gruenbacher <agruen>
Project Administrator
Tue 12 Oct 2010 01:49:20 PM UTC, original submission:

How to reproduce (with patch 2.6.1): First download and unpack some files:

pipping@bogus ~/tmp $ wget --user-agent=whatever http://mamedev.org/updates/0139u1_diff.zip 2>/dev/null; echo $?
0
pipping@bogus ~/tmp $ wget --user-agent=whatever 'http://mamedev.org/downloader.php?&file=mame0139s.zip' 2>/dev/null; echo $?
0
pipping@bogus ~/tmp $ unzip mame0139s.zip >/dev/null; echo $?
0
pipping@bogus ~/tmp $ unzip mame.zip >/dev/null; echo $?
0
pipping@bogus ~/tmp $ unzip 0139u1_diff.zip >/dev/null; echo $?
0
pipping@bogus ~/tmp $

Now for the important part:

pipping@bogus ~/tmp $ patch -p0 -f --dry-run >/dev/null < 0139u1.diff; echo $?
1
pipping@bogus ~/tmp $ patch -p0 -f --binary --dry-run >/dev/null < 0139u1.diff; echo $?
0
pipping@bogus ~/tmp $ patch -p0 -f --binary --silent --dry-run >/dev/null < 0139u1.diff; echo $?
1
pipping@bogus ~/tmp $ patch -p0 -f --binary --silent --verbose --dry-run >/dev/null < 0139u1.diff; echo $?
0
pipping@bogus ~/tmp $

In other words: --binary works, adding --silent makes the patch fail and disabling --silent by passing --verbose makes it work again (there is no way to just disable --silent again but not enable --verbose, is there?)

Elias Pipping <pipping>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by agruen (Posted a comment)
  • -unavailable- added by pipping (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 13 Oct 2010 10:18:56 PM UTCagruenStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1