bugGnash - The GNU Flash player - Bugs: bug #31235, libcurl 7.21.x doesn't work wth...

 
 

bug #31235: libcurl 7.21.x doesn't work wth Gnash

Submitted by:  Rob Savoye <rsavoye>
Submitted on:  Sun 03 Oct 2010 07:00:41 PM UTC  
 
Category: coreSeverity: 4 - Important
Release: trunkStatus: Ready For Test
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 03 Oct 2010 11:56:52 PM UTC, comment #5:

sounds like it's fixed.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Sun 03 Oct 2010 09:30:36 PM UTC, comment #4:

it works here on f14 and it works, i did a scratch build :

http://koji.fedoraproject.org/koji/taskinfo?taskID=2509282

Hicham HAOUARI <hichamhaouari>
Project Member
Sun 03 Oct 2010 08:05:09 PM UTC, comment #3:

See talk #8193 for the select proble I was talking about

Sandro Santilli <strk>
Project Member
Sun 03 Oct 2010 08:04:01 PM UTC, comment #2:

The patch seems sane to me, except maybe we should sleep some between iterations, to avoid busy perform loops.

The select timeout might be good, why skipping that part ? Would it be an error to call select() with 0 filedescriptors ?

Note that the current select timeout (maxSleepUsec) is hardcoded,
while curl_multi_timeout() should be used instead, see http://curl.haxx.se/libcurl/c/curl_multi_fdset.html

Finally, I noticed we're calling FD_ZERO on filedescriptors after the curl_multi_fdset. It might explain a few problems with that select... (but unrelated to this patch).

Sandro Santilli <strk>
Project Member
Sun 03 Oct 2010 07:33:55 PM UTC, comment #1:

I attach a cleaner version of the patch, w/out indentation changes

(file #21604)

Anonymous
Sun 03 Oct 2010 07:00:41 PM UTC, original submission:

As of libcurl 7.21.x, the DNS resolving appears to be going on in the background, so curl_multi_fdset() fails to return anything useful. So we use the user timeout value to give DNS enough time to resolve the lookup. This fix is required for Fedora 14 to work at all, and possibly other distributions.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21604:  libcurl_clean.patch added by None (1KiB - text/x-diff - cleaner version)
file #21603:  libcurl.patch added by rsavoye (3KiB - text/x-patch - patch that appears to fix Gnash with the latest libcurl)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by hichamhaouari (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by rsavoye (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 03 Oct 2010 11:56:52 PM UTCrsavoyeOpen/ClosedOpen=>Closed
    Sun 03 Oct 2010 08:04:01 PM UTCstrkCategoryNone=>core
    Sun 03 Oct 2010 07:33:55 PM UTCNoneAttached File-=>Added libcurl_clean.patch, #21604
    Sun 03 Oct 2010 07:00:42 PM UTCrsavoyeAttached File-=>Added libcurl.patch, #21603

    Back to the top


    Powered by Savane 3.1-cleanup1