bugGNU Wget - Bugs: bug #31147, Patch: --match-query-string option...

 
 

bug #31147: Patch: --match-query-string option to add query string to accept/reject lists

Submitter:  SineSwiper <sineswiper>
Submitted:  Tue 28 Sep 2010 12:24:14 AM UTC
   
 
Category:  Feature Request Severity:  3 - Normal
Priority:  5 - Normal Status:  Wont Fix
Privacy:  Public Assigned to:  gscrivano
Originator Name:  SineSwiper Open/Closed:  Closed
Release:  None Operating System:  GNU/Linux
Reproducibility:  Every Time Fixed Release:  None
Planned Release:  None Regression:  None
Work Required:  None Patch Included:  Yes
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 18 Apr 2012 01:17:44 PM UTC, comment #4: 

That's fine, just as long as there's an existing bug tracking the new feature and that there is traction on getting this kind of functionality implemented.  This sort of thing is getting to be a lot more important, as most of the web already works through dynamic pages and query strings.

Is this new RegExp accept/reject feature already on the bug tracker?  If so, what's the #?

SineSwiper <sineswiper>
Sat 14 Apr 2012 10:28:54 AM UTC, comment #3: 

There is a more interesting patch which was posted on the wget mailing list:

http://lists.gnu.org/archive/html/bug-wget/2012-04/msg00009.html

It covers also the --match-query-string case.

Giuseppe Scrivano <gscrivano>
Group administrator
Sat 14 Apr 2012 09:18:52 AM UTC, comment #2: 

the patch is just a quick hack to get it working in a particular case.  I have to rework it before I can apply it.

Giuseppe Scrivano <gscrivano>
Group administrator
Fri 23 Dec 2011 07:55:21 PM UTC, comment #1: 

Any progress on this one?

SineSwiper <sineswiper>
Tue 28 Sep 2010 12:24:14 AM UTC, original submission:  

In the docs, there is a paragraph here:

---
Note, too, that query strings (strings at the end of a URL beginning with a question mark (‘?’) are not included as part of the filename for accept/reject rules, even though these will actually contribute to the name chosen for the local file. It is expected that a future version of Wget will provide an option to allow matching against query strings.
---

Well, this is the patch for that future version.  Fairly simple change when the right code was found.  The option code actually takes up more space.

I have a few minor mistakes in the docs part of the patch.  I edited the .pod file without realizing the texi file is the original, so if you can convert that to texi code, that would be great.  Also, probably need to add the option in the "6.3 Wgetrc Commands" section of the .info file.

But, the code seems to work just fine.  Enjoy and please add it in the next version soon.  As the web gets more dynamic, this option gets to be more critical.

SineSwiper <sineswiper>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #21559:  wget-patch.txt added by sineswiper (6KiB - text/plain - Wget --match-query-string patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gscrivano (Posted a comment)
  • -email is unavailable- added by sineswiper (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-04-14 gscrivano StatusNone Wont Fix
        Assigned toNone gscrivano
        Open/ClosedOpen Closed
        Release1.12 None
    2010-09-28 sineswiper Attached File- Added wget-patch.txt, #21559

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code