bugPSPP - Bugs: bug #31016, Crash parsing arguments to DO...

 
 

bug #31016: Crash parsing arguments to DO REPEAT.

Submitted by:  John Darrington <jmd>
Submitted on:  Sat 11 Sep 2010 09:04:50 AM UTC  
 
Category: Syntax ParserSeverity: 7 - Major
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 28 Sep 2010 01:57:40 AM UTC, comment #2:

I pushed a fix for this bug (different from the one submitted by Terry).

Ben Pfaff <blp>
Project Administrator
Mon 27 Sep 2010 09:04:18 PM UTC, comment #1:

As far as I can tell, there are two issues with this bug.

First,

I believe crash.sps has a syntax error on line 27.

Instead of ' end do.',

it should be ' end repeat.'

Making this change to crash.sps makes the program run properly.

Second,

pspp is not properly handling the invalid syntax. For that, I have attached a patch file (crash.patch) to the source which changes pspp to properly detect the invalid syntax and output the offending line.

To apply the patch:

cd pspp-0.7.5-g8a0397
patch -p1 < crash.patch

(file #21558)

Terry W Droeger <tdroeger>
Sat 11 Sep 2010 09:04:50 AM UTC, original submission:

This syntax in the attached file causes an assertion failure in the lexer.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21558:  crash.patch added by tdroeger (2KiB - text/x-patch - Here is a patch file that provides a fix)
file #21434:  crash.sps added by jmd (347B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Posted a comment)
  • -unavailable- added by tdroeger (Updated the item)
  • -unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 28 Sep 2010 01:57:40 AM UTCblpStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 27 Sep 2010 09:04:18 PM UTCtdroegerAttached File-=>Added crash.patch, #21558
    Sat 11 Sep 2010 09:04:50 AM UTCjmdAttached File-=>Added crash.sps, #21434

    Back to the top


    Powered by Savane 3.1-cleanup1