bugGNUstep - Bugs: bug #30724, To determine FixPitch trait we...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30724: To determine FixPitch trait we need to ask for spacing infomation.

Submitted by:  Derek Fawcus <dfawcus>
Submitted on:  Tue 10 Aug 2010 08:09:11 AM UTC  
 
Category: BackendSeverity: 3 - Normal
Item Group: BugStatus: Ready For Test
Privacy: PublicAssigned to: Gregory John Casamento <gcasa>
Open/Closed: Closed

Tue 21 Oct 2014 01:12:13 PM UTC, comment #2:

No comment by the original owner, I suppose the bug is fixed.

Riccardo Mottola <rmottola>
Project Member
Tue 10 Aug 2010 07:28:22 PM UTC, comment #1:

Thank you for this simple patch. Should be fixed in SVN now.

Fred Kiefer <FredKiefer>
Project Member
Tue 10 Aug 2010 08:09:11 AM UTC, original submission:

The Xft fontconfig enumerator (the the cairo one based on it) share a bug in that the FixPitch trait is not correctly calculated. This is because it depends upon the presense of the FC_SPACING attribute, and only those attributes explicitly requested are included in the results from the search.

The below patch is against the refactored version of the code I've not yet shown, however it is obvious how to manually apply it to both the Xft and Cairo code.

Author: Derek Fawcus <dfawcus@employees.org>
Date: Thu Aug 5 22:18:09 2010 +0100

To determine FixPitch trait we need to ask for spacing infomation.

diff --git a/Source/x11/FcFontEnumerator.m b/Source/x11/FcFontEnumerator.m
index 9a76bea..9bdd49f 100644
--- a/Source/x11/FcFontEnumerator.m
+++ b/Source/x11/FcFontEnumerator.m
@@ -144,7 +144,7 @@ static NSArray faFromFc(FcPattern pat)
NSMutableArray *fc_allFontNames = [[NSMutableArray alloc] init];

FcPattern *pat = FcPatternCreate();
- FcObjectSet *os = FcObjectSetBuild(FC_FAMILY, FC_SLANT, FC_WEIGHT, NULL);
+ FcObjectSet *os = FcObjectSetBuild(FC_FAMILY, FC_SLANT, FC_WEIGHT, FC_SPACING, NULL);
FcFontSet *fs = FcFontList(0, pat, os);

FcPatternDestroy(pat);

Derek Fawcus <dfawcus>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rmottola (Posted a comment)
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by dfawcus (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 21 Oct 2014 01:12:13 PM UTCrmottolaOpen/ClosedIn Test=>Closed
    Tue 10 Aug 2010 07:28:22 PM UTCFredKieferStatusNone=>Ready For Test
      Assigned toNone=>gcasa
      Open/ClosedOpen=>In Test

    Back to the top


    Powered by Savane 3.1-cleanup1