bugGNU GRUB - Bugs: bug #30567, PATCH INCLUDED - override...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30567: PATCH INCLUDED - override grub_probe calls from the environment and to produce helpful verbose output

Submitted by:  Marc Haber <zugschlus>
Submitted on:  Tue 27 Jul 2010 04:41:30 PM UTC  
 
Category: ConfigurationSeverity: Major
Priority: 3 - LowItem Group: Feature Request
Status: Wont FixPrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: ClosedRelease: 
Release: Bazaar - trunkReproducibility: None
Planned Release: None

Fri 31 Dec 2010 01:18:45 PM UTC, comment #4:

You're faster than light. Thanks a lot.

Greetings
Marc

Marc Haber <zugschlus>
Fri 31 Dec 2010 01:16:26 PM UTC, comment #3:

It won't be changed for 1.99 release in any case. I marked the issue as "look into it later".

Vladimir Serbinenko <phcoder>
Project Administrator
Fri 31 Dec 2010 01:05:17 PM UTC, comment #2:

Hi

I missed your fast answer and apologize for that.

Please reconsider your decision:

(1)
grub-probe misdetecting things is not necessarily a bug. There are valid scenarios where grub-probe cannot possibly detect where grub will boot from. For example, I install grub to a /boot file system which is on a crypto device because my initramfs contains secret keys that shouldn't be on an unencrypted hard disk. The resulting /boot is then unisoned to an USB stick from where the system will actually boot. Having an encrypted /boot allows updates to happen without the USB stick.

(2)
sh -x doesn't propagate itself to daughter scripts. An environment variable does. Additionally, having to use sh -x to debug a package is usually considered a work around for poor debugging facilities.

Please reconsider, thanks.

Greetings
Marc

Marc Haber <zugschlus>
Tue 27 Jul 2010 09:31:47 PM UTC, comment #1:

Overriding from environment isn't a good idea. It only hides the real bug. As for verbose messages: why isn't sh -x enough?

Vladimir Serbinenko <phcoder>
Project Administrator
Tue 27 Jul 2010 04:41:30 PM UTC, original submission:

The attached patch for grub_mkconfig adds a --verbose command line option, uses it to print some helpful hints about grub-probe calls and their results, and allows the grub-probe stuff to be overridden from the environment, which is really helpful in cases where grub-probe misdetects (mostly when testing scripts in a chroot).

Please consider applying this patch to grub2 in bzr.

Greetings
Marc

Marc Haber <zugschlus>

 

Attached Files
file #21088:  grub-mkconfig.diff added by zugschlus (3KiB - text/x-patch - Patch, ready to be applied)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by zugschlus (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 27 Aug 2010 02:01:33 AM UTCphcoderStatusNone=>Wont Fix
      Open/ClosedOpen=>Closed
    Tue 27 Jul 2010 09:31:47 PM UTCphcoderPriority5 - Normal=>3 - Low
    Tue 27 Jul 2010 04:41:30 PM UTCzugschlusAttached File-=>Added grub-mkconfig.diff, #21088

    Back to the top


    Powered by Savane 3.1-cleanup1