bugGNUstep - Bugs: bug #30511, the change to NSString.m in r31003...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30511: the change to NSString.m in r31003 is wrong for NSString subclasses

Submitted by:  Doug Simons <theeggcamefirst>
Submitted on:  Wed 21 Jul 2010 09:23:59 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Thu 22 Jul 2010 06:11:58 AM UTC, comment #1:

I reverted that change entirely ... as far as I can see it's totally wrong.

Judging by the comment in the subversion log, It may have been intended as a hack to wallpaper over a bug in NSProxy/NSInvocation ... but there's no evidence of such a bug on my machines (though I haven't tested on a 64bit CPU).

Richard Frith-Macdonald <CaS>
Project Member
Wed 21 Jul 2010 09:23:59 PM UTC, original submission:

This change breaks equality testing for my subclass of NSString. Two strings which are equal (one of which is an instance of my custom subclass of NSString, and the other an instance of GSCInlineString) now return NO to the isEqual: method.

Perhaps what was meant was to test [aString isKindOfClass:[NSString class]] rather than [aString isKindOfClass:[self class]]? I just tried that change and it fixes the problem for me, but I don't understand the intent of this line.

Doug Simons <theeggcamefirst>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by theeggcamefirst (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 22 Jul 2010 06:11:58 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1