bugGNU Octave - Bugs: bug #30481, cquad integrator, Octave and...

 
 

bug #30481: cquad integrator, Octave and Oct-File sources

Submitted by:  Pedro Gonnet <gonnetp>
Submitted on:  Mon 19 Jul 2010 07:59:07 AM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: None
Originator Name: Pedro GonnetOpen/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 08 Oct 2010 09:11:31 AM UTC, comment #9:

Have the changes to the documentation been added? Was everything ok with the diff-file?

Cheers, Pedro

Pedro Gonnet <gonnetp>
Tue 14 Sep 2010 11:33:14 AM UTC, comment #8:

I've gone through the documentation and added cquad to quad.txi. I've also updated the "see also" strings of the other integrators.

Please let me know if the attached diff-file is ok!

Cheers, Pedro.

(file #21453)

Pedro Gonnet <gonnetp>
Wed 08 Sep 2010 07:07:04 PM UTC, comment #7:

But cquad is calling the user function with a vector, while quadpack, by the way its written is calling the user function with scalar arguments.. If the user function is vectorrized, this is a huge win for cquad, at least with Octave. A simple test to show what I mean with an oscillatory function :

octave:1> f = @(x) sin(1 ./ x);
octave:2> tic; quad(f,5e-4,1); toc
Elapsed time is 0.279176 seconds.
octave:3> tic; cquad(f,5e-4,1);toc
Elapsed time is 0.146284 seconds.

D.

David Bateman <dbateman>
Project Member
Wed 08 Sep 2010 09:54:46 AM UTC, comment #6:

I wouldn't... Although cquad is more reliable, the QUADPACK routines are usually more efficient for functions that are well-behaved, i.e. have no singularities, discontinuities or other surprises.

Replacing them may cause a flood of "quad is all of a sudden much slower for my function!" bug reports.

Cheers, Pedro

Pedro Gonnet <gonnetp>
Wed 08 Sep 2010 09:35:09 AM UTC, comment #5:

Shouldn't the cquad function superceed the QUADPACK quadrature functions? CQUAD was shown to be faster, more accurate and reentrant so that nested calls were possible (think N-D quadrature). I'd say we should dump QUADPACK and just use CQUAD.

Cheers
David

David Bateman <dbateman>
Project Member
Mon 06 Sep 2010 09:23:44 AM UTC, comment #4:

Uh, sorry, I just forgot to push.

Jaroslav Hajek <highegg>
Mon 06 Sep 2010 09:20:51 AM UTC, comment #3:

Jaroslav,

You closed this feature request, but the cquad code doesn't appear in the repository. Do you intend to replace the quadpack integrators will this code?

D.

David Bateman <dbateman>
Project Member
Fri 03 Sep 2010 11:25:15 AM UTC, comment #2:

Added. Thanks!

Jaroslav Hajek <highegg>
Wed 25 Aug 2010 09:59:13 AM UTC, comment #1:

cquad_consts.h is missing. Could you please upload it as well?

Jaroslav Hajek <highegg>
Mon 19 Jul 2010 07:59:07 AM UTC, original submission:

Hi all,

Jaroslav suggested I submit this as a feature request, so here it is! Please find attached both the Octave and Oct-File versions of the integrator and let me know if you need anything else!

Cheers, Pedro

Pedro Gonnet <gonnetp>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21453:  changes.diff added by gonnetp (6KiB - application/octet-stream)
file #21298:  cquad_consts.h added by gonnetp (75KiB - application/octet-stream)
file #21007:  cquad.C added by gonnetp (27KiB - application/octet-stream)
file #21008:  cquad.h added by gonnetp (1KiB - application/octet-stream)
file #21009:  cquad.m added by gonnetp (17KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by siko1056 (Updated the item)
  • -unavailable- added by dbateman (Posted a comment)
  • -unavailable- added by highegg (Updated the item)
  • -unavailable- added by gonnetp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Sep 2015 02:45:52 PM UTCsiko1056StatusPatch Submitted=>Fixed
      Assigned tohighegg=>None
    Tue 14 Sep 2010 11:33:14 AM UTCgonnetpAttached File-=>Added changes.diff, #21453
    Fri 03 Sep 2010 11:25:15 AM UTChigheggStatusNone=>Patch Submitted
      Open/ClosedOpen=>Closed
    Wed 25 Aug 2010 10:02:09 AM UTCgonnetpAttached File-=>Added cquad_consts.h, #21298
    Mon 16 Aug 2010 08:08:16 AM UTChigheggAssigned toNone=>highegg
    Mon 19 Jul 2010 07:59:07 AM UTCgonnetpAttached File-=>Added cquad.C, #21007
      Attached File-=>Added cquad.h, #21008
      Attached File-=>Added cquad.m, #21009

    Back to the top


    Powered by Savane 3.1-cleanup1