bugGNU GRUB - Bugs: bug #30452, [PATCH] Correctly set RSDT OEM...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30452: [PATCH] Correctly set RSDT OEM table ID

Submitted by:  Luca Barbieri <luca_barbieri>
Submitted on:  Thu 15 Jul 2010 02:20:54 PM UTC  
 
Category: BootingSeverity: Major
Priority: 5 - NormalItem Group: Software Error
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: ClosedRelease: 
Release: Bazaar - trunkReproducibility: Every Time
Planned Release: None

Tue 20 Jul 2010 12:43:49 PM UTC, comment #1:

Changed to sizeof. Thanks. Can you retest?

Vladimir Serbinenko <phcoder>
Project Administrator
Thu 15 Jul 2010 02:20:54 PM UTC, original submission:

Currently GRUB only sets the first 4 characters of the RSDT OEM table ID, which is 8 characters long.

This means that loadyng a new table will corrupt the RSDT OEM table ID, potentially leading to serious problems.

This patch trivially fixes this. It is released to the public domain.

---
commands/acpi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/commands/acpi.c b/commands/acpi.c
index 9cfd8ef..2fbe6c1 100644
--- a/commands/acpi.c
+++ b/commands/acpi.c
@@ -358,7 +358,7 @@ setup_common_tables (void)
rsdt->length = sizeof (struct grub_acpi_table_header) + 4 * numoftables;
rsdt->revision = 1;
grub_memcpy (&(rsdt->oemid), root_oemid, 6);
- grub_memcpy (&(rsdt->oemtable), root_oemtable, 4);
+ grub_memcpy (&(rsdt->oemtable), root_oemtable, 8);
rsdt->oemrev = root_oemrev;
grub_memcpy (&(rsdt->creator_id), root_creator_id, 6);
rsdt->creator_rev = root_creator_rev;
--
1.7.0.4

Luca Barbieri <luca_barbieri>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by luca_barbieri (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 20 Jul 2010 12:43:49 PM UTCphcoderStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1