bugGNU GRUB - Bugs: bug #30364, ...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30364: grub-mkconfig(/etc/grub.d/10_linux) ignores builtin initrds

Submitted by:  Dennis Schridde <devurandom>
Submitted on:  Tue 06 Jul 2010 06:24:58 AM UTC  
 
Category: ConfigurationSeverity: Major
Priority: 5 - NormalItem Group: Software Error
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: ClosedRelease: 
Release: 1.98Reproducibility: Every Time
Planned Release: None

Mon 01 Nov 2010 11:54:22 AM UTC, comment #2:

Issue is likely to be fixed in mainline and original reporter failed to answer retest request. Closing. If it still persists feel fre to reopen

Vladimir Serbinenko <phcoder>
Project Administrator
Mon 18 Oct 2010 01:45:52 PM UTC, comment #1:

Your patch doesn't take care of all version formats supported and is really not checking if CONFIG_INITRAMFS_SOURCE is empty or not.

I have fixed this issue in mainline with different patch, can you test it and confirm?

BVK Chaitanya <bvk>
Project Member
Tue 06 Jul 2010 06:24:58 AM UTC, original submission:

When CONFIG_INITRAMFS_SOURCE is set, no seperate initrd is necessary.
grub-mkconfig from grub-1.98 (specifically /etc/grub.d/10_linux)
ignores this and assumes:
"""
# "UUID=" magic is parsed by initrds. Since there's no initrd, it can't work
here
"""

I propose following fix:
--- /etc/grub.d/10_linux.orig 2010-06-28 14:22:06.080669780 +0200
+++ /etc/grub.d/10_linux 2010-06-28 14:21:24.177670182 +0200
@@ -128,7 +128,7 @@
done
if test -n "${initrd}" ; then
echo "Found initrd image: ${dirname}/${initrd}" >&2
- else
+ elif ! grep "CONFIG_INITRAMFS_SOURCE=" /boot/config-${version} 2> /dev/null
; then
# "UUID=" magic is parsed by initrds. Since there's no initrd, it can't
work here.
linux_root_device_thisversion=${GRUB_DEVICE}

Dennis Schridde <devurandom>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by phcoder (Posted a comment)
  • -unavailable- added by bvk (Posted a comment)
  • -unavailable- added by devurandom (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 01 Nov 2010 11:54:22 AM UTCphcoderStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1