bugGnash - The GNU Flash player - Bugs: bug #30242, "Scriptable variables"...

 
 

bug #30242: "Scriptable variables" wrong

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Thu 24 Jun 2010 10:37:43 AM UTC  
 
Category: NoneSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Jun 2010 05:08:01 PM UTC, comment #3:

Fixed, thanks.

Benjamin Wolsey <bwy>
Project Member
Thu 24 Jun 2010 03:43:20 PM UTC, comment #2:

Fixed as of revno #12274. Eventually all the flashVars also become accessible to ExternalInterface, and the browser can then later set/get the values from Javascript. However since the last little bits to actually set/get scriptable variables doesn't exist, there is no reason to set them here.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 24 Jun 2010 01:08:27 PM UTC, comment #1:

The scriptable vars should have no effect on what gets passed with -P, their values are only used over the socket connection. If you mean the additional argument passed to movie_root, that could be dropped for now, as there is no support for actually setting or getting real values for the scriptables anyway. The test for scriptables is in plugin/npapi, it's an HTML page.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 24 Jun 2010 10:37:43 AM UTC, original submission:

The following command should run a twitter application for the user id 7670202, but it gets the messages of a different user. This is a regression.

The reason is the "scriptable vars". These take the non-flashvars such as src, name, quality etc, and set them as variables in the movie.

To test that this isn't correct behaviour, simply trace "_root.src" in a movie that's embedded with a src tag. It should not trace anything in the proprietary plugin.

Either dropping all the non-flashvars -P commands or not setting the scriptable variables in gui/Player.cpp fixes the bug.

gui/gtk-gnash -U 'http://questionablecontent.net/' -P 'align=middle' -P 'allowscriptaccess=always' -P 'flashvars=color1=10066329&type=user&id=7670202' -P 'height=176' -P 'name=twitter_badge' -P 'pluginspage=http://www.macromedia.com/go/getflashplayer' -P 'quality=high' -P 'src=http://twitter.com/flash/twitter_badge.swf' -P 'type=application/x-shockwave-flash' -P 'width=176' -P 'wmode=transparent' 'http://twitter.com/flash/twitter_badge.swf' $@ -vv

Can we drop the scriptable vars? It seems no tests rely on them, and whatever they're supposed to do, it's currently not correct.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 24 Jun 2010 05:08:01 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 24 Jun 2010 03:43:20 PM UTCrsavoyeStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1