bugGNUstep - Bugs: bug #30069, Some images drawn offset on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30069: Some images drawn offset on Windows since r30523

Submitted by:  Doug Simons <theeggcamefirst>
Submitted on:  Mon 07 Jun 2010 04:36:46 PM UTC  
 
Category: BackendSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Quentin Mathé <qmathe>
Open/Closed: Closed

Wed 23 Jun 2010 05:07:45 PM UTC, comment #3:

Fantastic! It appears to be working perfectly now. Thank you, Quentin!

Doug Simons <theeggcamefirst>
Tue 22 Jun 2010 10:42:59 PM UTC, comment #2:

Hi Doug,

This issue should now be fixed with r30829

Various limitations still remain. -compositeGState and related -compositeToPoint: methods are broken in a way similar to Cairo. When the context is rotated, the origin is wrong.

Alpha blending doesn't work in some cases (rotated or scaled context but I'm not sure), I just get a yellow rectangle.

-drawInRect: and similar methods from NSImage now work correctly in a rotated/scaled context, the image is now drawn at the right location.

I initially wrote a patch that corrects the -compositeGState issue and is also a bit cleaner that the one I committed. But because of a weird issue I discuss in the -DPSimage note comment, I had to give up this approach.

Given this GDI backend should be deprecated in favor of Opal/Cairo at some point, I don't think putting more effort in improving it is worth the investment.

Let me know if you encounter any issue with the changes I committed,
Quentin.

Quentin Mathé <qmathe>
Project MemberIn charge of this item.
Sat 19 Jun 2010 02:49:40 PM UTC, comment #1:

Just let you know… I'm still working on it, but it's harder than expected.

Quentin Mathé <qmathe>
Project MemberIn charge of this item.
Mon 07 Jun 2010 04:36:46 PM UTC, original submission:

The changes made to the drawing code in r30523 cause some images to be drawn lower on the screen than they should on Windows, as shown in these screen shots of an image in a tableView:

http://www.testplant.com/img/Before30523.png
http://www.testplant.com/img/After30523.png

Doug Simons <theeggcamefirst>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Updated the item)
  • -unavailable- added by qmathe (Posted a comment)
  • -unavailable- added by theeggcamefirst (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 26 Jul 2010 08:36:46 PM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 22 Jun 2010 10:42:59 PM UTCqmatheCategoryGui/AppKit=>Backend
      StatusNone=>Ready For Test
      Assigned toNone=>qmathe

    Back to the top


    Powered by Savane 3.1-cleanup1