bugGnash - The GNU Flash player - Bugs: bug #30057, [PATCH] Fix build of KDE4 GUI

 
 

bug #30057: [PATCH] Fix build of KDE4 GUI

Submitted by:  Thomas Koeller <tkoeller>
Submitted on:  Sun 06 Jun 2010 09:13:52 PM UTC  
 
Category: buildSeverity: 3 - Normal
Release: trunkStatus: Fixed
Privacy: PublicAssigned to: John Wimer <vipw>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 13 Jan 2011 09:37:01 AM UTC, comment #5:

I kind of agree with Thomas here, but anyway John is maintaining the kde stuff, so I'd leave him the last word about it.

John: shall you close this if completed ?

Sandro Santilli <strk>
Project Member
Sun 13 Jun 2010 11:24:09 AM UTC, comment #4:

Forgive me if I am wrong, but isn't this a bit inconsistent? I suppose you are not going to replace all occurences of things like '#include <boost/date_time/posix_time/posix_time.hpp>' with just the plain file names and add all those subdirectory paths to the include path? So what is so special about Qt that it has to be handled diferently?

Thomas Koeller <tkoeller>
Sat 12 Jun 2010 01:55:14 PM UTC, comment #3:

This should be fixed as of revision 12247.
The subdirectories are added to the include path instead of changing the sources. I thought it was worth copying pkg-config's approach.

John Wimer <vipw>
Project MemberIn charge of this item.
Mon 07 Jun 2010 10:23:28 PM UTC, comment #2:

The OS is Linux/KDE4. I installed Qt from git sources (the KDE repository branch kde/4.6.2-patched).

Changing the include path would have been easier, that's true, but thats a workaround, not a fix. When building against external libraries that install their headers in some subdirectory of the top-level include directory, it is common practice to do it like I did in my patch. I used the '--with-qt4-incl' configure option, and that should be sufficient. The tree layout underneath the top-level include directory is fixed, and there is no point in setting up the include path to contain all the subdirectories explicitly.

Thomas Koeller <tkoeller>
Mon 07 Jun 2010 01:07:02 PM UTC, comment #1:

Which OS is this for?

It would have been a lot easier for you to change the include path instead of changing every Qt include. I'm curious why the configure script didn't automatically set it up for you.

Nice catch on macros/x11.m4, that's been broken for a few years.

John Wimer <vipw>
Project MemberIn charge of this item.
Sun 06 Jun 2010 09:13:52 PM UTC, original submission:

In order to build the KDE4 GUI, I had to apply the changes contained in the attached patch. Many Qt include files could not be found due to incomplete paths, and the link step failed because of a missing -L option for the X11 library path.

Thomas Koeller <tkoeller>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20698:  gnash.patch added by tkoeller (6KiB - text/x-patch - Patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Updated the item)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by vipw (Posted a comment)
  • -unavailable- added by tkoeller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 08 Mar 2011 01:43:09 AM UTCbjacquesOpen/ClosedOpen=>Closed
    Thu 13 Jan 2011 09:37:01 AM UTCstrkAssigned toNone=>vipw
    Sat 12 Jun 2010 01:55:14 PM UTCvipwStatusNone=>Fixed
    Sun 06 Jun 2010 09:13:52 PM UTCtkoellerAttached File-=>Added gnash.patch, #20698

    Back to the top


    Powered by Savane 3.1-cleanup1