bugXBoard - Bugs: bug #29962, configure.ac has unnecessary...

 
 

bug #29962: configure.ac has unnecessary bashisms

Submitted by:  Clint Adams <clint>
Submitted on:  Wed 26 May 2010 01:23:57 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Assigned to: Arun Persaud <apersaud>Open/Closed: Closed
Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 05 Jun 2010 08:12:13 PM UTC, comment #3:

Applied your patch. Thanks for the contribution :)

Arun Persaud <apersaud>
Project AdministratorIn charge of this item.
Wed 26 May 2010 02:47:09 PM UTC, comment #2:

Oops, I'm wrong, "test" is built in to bash, and GNU /usr/bin/test does not recognize ==. I thought I had checked that before posting, but evidently I checked it in an invalid way.

Tim Mann <mann>
Project Administrator
Wed 26 May 2010 07:31:01 AM UTC, comment #1:

Technically that might be a gnuism, but it isn't a bashism, because "test" in that context invokes /usr/bin/test as a separate program. "test" isn't built in to bash.

However, I'm just quibbling here. Your change is good. Thanks.

Tim Mann <mann>
Project Administrator
Wed 26 May 2010 01:23:57 AM UTC, original submission:

The portable binary equality operator to test is "=", not "==". The former works portably on more shells.

Clint Adams <clint>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by apersaud (Posted a comment)
  • -unavailable- added by mann (Posted a comment)
  • -unavailable- added by clint (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 05 Jun 2010 08:12:13 PM UTCapersaudStatusNone=>Fixed
      Assigned toNone=>apersaud
      Open/ClosedOpen=>Closed
    Wed 26 May 2010 01:23:57 AM UTCclintAttached File-=>Added 0001-Remove-unnecessary-double-equals-from-configure.ac.patch, #20620

    Back to the top


    Powered by Savane 3.1-cleanup1