bugGNUstep - Bugs: bug #29871, item size not respected in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29871: item size not respected in NSToolBar (Search field in Grr)

Submitted by:  Riccardo Mottola <rmottola>
Submitted on:  Wed 12 May 2010 10:10:18 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Mon 17 May 2010 10:49:09 PM UTC, comment #3:

I think the current behaviour is correct now. At least, Grr matches what Cocoa does.
I think we described it the last time correclty, btu perhaps we misunderstood each other, since I described the behaviour during the procedure of making things smaller.

First all white space is eaten up, then flexible items are gradually resize to their minimum, then items overflow.

Riccardo Mottola <rmottola>
Project Member
Thu 13 May 2010 04:31:04 PM UTC, comment #2:

I changed the code to expand the flexible items first before expanding the flexible space. This feels correct, so I committed it. Please test this.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Thu 13 May 2010 02:36:19 PM UTC, comment #1:

I just added code to SVN that handles the resizing of the toolbar a lot better. What we do not is when there isn't any flexible space in the toolbar, then all the items will be scaled up to there maximum size. (This only works for items backed up with a custom view at the moment)
Now in Grr we have a flexible space present in the toolbar. This results in no visible difference between the current code and the old one. To address this we will have to redefine the way toolbars resize their items. In a private communication a few months back we defined that first flexible spaces get resized and only if none is present the other items will resize.
What you are requesting now for Grr seems to be more in the line of: First resize all flexible items up to their maximum size and only if there is space left resize flexible spaces to fill this up.

Implementing this new behaviour isn't that difficult, but we first have to agree that this is really what we want. Perhaps I did misunderstand you at that time? I will try out the new behaviour and commit it if it feels correct.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Wed 12 May 2010 10:10:18 PM UTC, original submission:

The search field in Grr does not instantiate in the correct size even if there is enough space for that.

Grr is available in gap and it should look like this:

http://multixden.blogspot.com/2010/02/grr-working-on-windows.html

Riccardo Mottola <rmottola>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by rmottola (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 18 May 2010 07:46:52 PM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Thu 13 May 2010 04:31:04 PM UTCFredKieferItem GroupNone=>Change Request
      StatusNone=>Ready For Test
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>In Test

    Back to the top


    Powered by Savane 3.1-cleanup1