bugGNU Octave - Bugs: bug #29841, Feature request: conv update

 
 

bug #29841: Feature request: conv update

Submitted by:  spasmous <spasmous>
Submitted on:  Sun 09 May 2010 09:01:46 PM UTC  
 
Category: NoneSeverity: 1 - Wish
Priority: 1 - LaterItem Group: Feature Request
Status: NoneAssigned to: None
Originator Name: Open/Closed: Closed
Release: 3.3.51Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 16 May 2011 05:15:04 PM UTC, comment #5:

It was closed because there had been no action on the part of the original coder/proposer in 1 year. Also, conv() now supports the shape arguments 'same' and 'full' which were the impetus for the original report. Adding a 'circ' option might be nice, but it would be above and beyond Matlab compatibility and perhaps belongs in either a new function cconv() or an Octave-Forge package.

Rik <rik5>
Project Administrator
Mon 16 May 2011 01:22:11 PM UTC, comment #4:

Why was this closed?

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Thu 13 May 2010 07:03:55 PM UTC, comment #3:

The most up-to-date practices for Octave code are found in the section titled "Contributing Guidelines" in the pdf documentation.

In short, we can always deal with context diffs, but it is easier if you can try out the Mercurial version control system and prepare patches with that tool. However, I understand if you don't want to learn yet another source code control system.

Also, before you make changes I would benchmark the current code. You don't want to slow things down while tweaking the code.
The following code is crude but does the job.

a = rand(10000,1);
b = rand(10000,1);
tic; c = conv(a,b); toc;

Rik <rik5>
Project Administrator
Thu 13 May 2010 06:22:39 PM UTC, comment #2:

Why would you want to remove the 'conv' function?

Søren Hauberg <hauberg>
Thu 13 May 2010 06:17:52 PM UTC, comment #1:

Hi - I'd like to have a go at making the change myself. It will be my first patch. I'm going to follow the advice here, unless there is another recommended way for submitting changes.

http://www.gnu.org/software/octave/bugs.html

Three things I will propose:

1. Remove the conv.m function.
2. Make convn.cc accept 1D arguments.
3. Add 'circ' as a convolution type.

The last is a feature that is not in MATLAB but should be :)

spasmous <spasmous>
Sun 09 May 2010 09:01:46 PM UTC, original submission:

In the latest MATLAB, conv now accepts a 3rd argument to specify the type of convolution, e.g. 'same', 'valid' and 'full'.

octave:1> a=randn(5,1);
octave:2> b=randn(7,1);
octave:3> conv(a,b,'same')
error: Invalid call to conv. Correct usage is:
-- Function File: conv (A, B)

If I may make a feature request: please add circular convolution 'circ' as a type. The Mathworks don't seem motivated to include this, I guess because it overlaps with their toolbox function cconv. Thanks.

spasmous <spasmous>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by hauberg (Posted a comment)
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by spasmous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 16 May 2011 03:07:16 AM UTCrik5StatusIn Progress=>None
      Open/ClosedOpen=>Closed
    Thu 16 Sep 2010 06:31:32 PM UTCjwePriority5 - Normal=>1 - Later
    Thu 13 May 2010 07:03:55 PM UTCrik5StatusNone=>In Progress
    Tue 11 May 2010 04:44:44 PM UTCrik5Summaryconv update=>Feature request: conv update
    Mon 10 May 2010 01:47:46 AM UTCjweSeverity3 - Normal=>1 - Wish
      Item GroupNone=>Feature Request

    Back to the top


    Powered by Savane 3.1-cleanup1