bugGNU Scientific Library - Bugs: bug #29783, Missing cast on line 226 of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29783: Missing cast on line 226 of glfixed.c?

Submitted by:  Michael Forbes <mforbes>
Submitted on:  Wed 05 May 2010 01:05:41 AM UTC  
 
Category: BuildSeverity: 3 - Normal
Operating System: Status: Fixed
Assigned to: Rhys Ulerich <rhysu>Open/Closed: Closed
Release: 1.14

Thu 06 May 2010 02:43:58 PM UTC, comment #5:

Patch applied in
commit 1a4cf5e08da41f19c0f0af7a108779fccfc34148

Rhys Ulerich <rhysu>
Project AdministratorIn charge of this item.
Thu 06 May 2010 02:04:44 AM UTC, comment #4:

Glad the patch looks okay. Issue can be closed once the patch is incorporated. I lack the ability to changes the status fields (I think).

Go ahead and file the warnings so they're on record. As for the failed checks, what optimization level and compiler did you use? Intel's compilers don't tend to pass the GSL tests for things much beyond -O1, and sometimes not even -O1.

Rhys Ulerich <rhysu>
Project AdministratorIn charge of this item.
Thu 06 May 2010 12:34:09 AM UTC, comment #3:

Compiles fine now.

There were some failed checks (see attached check.log).

Also, some warnings were issued:

Let me know if I should submit these as a bug too.

(file #20459)

Michael Forbes <mforbes>
Wed 05 May 2010 10:32:02 PM UTC, comment #2:

Attached is a quick patch to add the cast. Build and make check pass cleanly on GCC 4.2.4. Would you please confirm it's good on your Intel version?

(file #20456)

Rhys Ulerich <rhysu>
Project AdministratorIn charge of this item.
Wed 05 May 2010 10:22:18 PM UTC, comment #1:

I just double checked trunk. Appears line 226 is the only place such a cast fails to appear for either a malloc or a calloc call.

Rhys Ulerich <rhysu>
Project AdministratorIn charge of this item.
Wed 05 May 2010 01:05:41 AM UTC, original submission:

I was having a problem building the gsl using the intel compiler.

icpc (ICC) 10.1 20071116
Copyright (C) 1985-2007 Intel Corporation. All rights reserved.

because of a lack of cast on line 226 of integration/glfixed.c. Adding the cast allowed the compilation to continue:

Michael Forbes <mforbes>

 

Attached Files
file #20459:  check.log added by mforbes (95KiB - application/octet-stream)
file #20456:  glfixed.malloc.cast.patch added by rhysu (473B - text/x-diff - Tentative patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rhysu (Posted a comment)
  • -unavailable- added by rhysu
  • -unavailable- added by mforbes (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 06 May 2010 02:43:58 PM UTCrhysuStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Thu 06 May 2010 07:27:25 AM UTCbjgStatusNone=>Confirmed
      Assigned toNone=>rhysu
    Thu 06 May 2010 12:34:09 AM UTCmforbesAttached File-=>Added check.log, #20459
    Wed 05 May 2010 10:32:02 PM UTCrhysuAttached File-=>Added glfixed.malloc.cast.patch, #20456
    Wed 05 May 2010 10:22:18 PM UTCrhysuCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1