bugGNUstep - Bugs: bug #29705, Windows: OpenGL subwindow...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29705: Windows: OpenGL subwindow positioning error

Submitted by:  Eric Wasylishen <ericw>
Submitted on:  Wed 28 Apr 2010 09:07:17 PM UTC  
 
Category: BackendSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Eric Wasylishen <ericw>
Open/Closed: Closed

Mon 26 Jul 2010 02:17:01 AM UTC, comment #1:

Fixed in r31029

Eric Wasylishen <ericw>
Project MemberIn charge of this item.
Wed 28 Apr 2010 09:07:17 PM UTC, original submission:

You can test this on Windows by setting GSBackHandlesWindowDecorations to YES, and running usr-apps/examples/gui/MyGL. When moving the splitter vertically, the position of the NSOpenGLViews will be incorrect (vertically flipped from where they should be.)

I have a proposed fix for this:

In w32_GLcontext.m there's this chunk of code:

if ([server handlesWindowDecorations] == YES)
{
/* The window manager handles window decorations, so the
* the parent X window is equal to the content view and
* we must therefore use content view coordinates.
*/
rect = [view convertRect: [view bounds] toView: [[attached window] contentView]];
}

However this doesn't take in to account whether [[attached window] contentView] is flipped or not - later on it is assumed that rect is unflipped.

I have attached a patch which ensures rect is in unflipped coordinates.

I believe this change also needs to be made in the X11 backend - XGGLContext has the same chunk of code. Perhaps we could a private method somewhere which handles this conversion.. -[NSView _convertRectToBackendCoordinates:] or something like that?

Eric Wasylishen <ericw>
Project MemberIn charge of this item.

 

Attached Files
file #20361:  w32_GLContext.patch added by ericw (873B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ericw (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 26 Jul 2010 02:17:01 AM UTCericwStatusReady For Test=>Fixed
      Assigned toNone=>ericw
      Open/ClosedOpen=>Closed
    Wed 28 Apr 2010 11:01:25 PM UTCericwStatusNone=>Ready For Test
    Wed 28 Apr 2010 09:07:17 PM UTCericwAttached File-=>Added w32_GLContext.patch, #20361

    Back to the top


    Powered by Savane 3.1-cleanup1