bugPSPP - Bugs: bug #29659, Clicking on upper-left corner of...

 
 

bug #29659: Clicking on upper-left corner of data sheet causes crash

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sat 24 Apr 2010 06:53:20 PM UTC  
 
Category: Graphical User InterfaceSeverity: 5 - Average
Status: NoneAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 May 2010 06:00:19 PM UTC, comment #2:

Thanks for the patch. It fixes the problem for me, too, so I pushed it out and I'm closing the bug.

Ben Pfaff <blp>
Project Administrator
Sat 08 May 2010 01:31:14 AM UTC, comment #1:

I think the problem is that psppire_sheet_select_range (lib/gtk-contrib/psppire-sheet.c:2710) doesn't support its second argument to be NULL, since it dereferences this argument.

But, on the same file, line 3027 we have:
psppire_sheet_select_range (sheet, NULL);

This only happens if both row and column are equal -1 which only happens if you click on the marked area.

Since click on this cell should do nothing, and there is already code to avoid problems with this click inside the if, I guess the best solution whould be simple remove line 3027.

The attached patch should do it, and also fix a strange line break on line 3026

(file #20478)

Michel Boaventura <michelboaventura>
Project Member
Sat 24 Apr 2010 06:53:20 PM UTC, original submission:

From original email archived at http://permalink.gmane.org/gmane.comp.statistics.pspp.user/806:

Image attached.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20314:  click-error.png added by blp (28KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by michelboaventura (Updated the item)
  • -unavailable- added by blp (Submitted the item)
  • -unavailable- added by blp
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 08 May 2010 06:00:18 PM UTCblpOpen/ClosedOpen=>Closed
    Sat 08 May 2010 01:31:14 AM UTCmichelboaventuraAttached File-=>Added fix_corner_click.patch, #20478
    Sat 24 Apr 2010 06:53:20 PM UTCblpAttached File-=>Added click-error.png, #20314
      Carbon-Copy-=>Added matej kovacic

    Back to the top


    Powered by Savane 3.1-cleanup1