bugfindutils - Bugs: bug #29593, import-gnulib has #!/bin/sh but is...

 
 

bug #29593: import-gnulib has #!/bin/sh but is not a POSIX sh script

Submitted by:  Andreas Metzler <ametzler>
Submitted on:  Sun 18 Apr 2010 10:56:04 AM UTC  
 
Category: NoneSeverity: 2 - Minor
Item Group: Compilation FailureStatus: Fixed
Privacy: PublicAssigned to: James Youngman <jay>
Originator Name: Open/Closed: Closed
Release: 4.5.8Fixed Release: 4.5.9

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 18 Apr 2010 11:55:39 AM UTC, comment #1:

I just pushed a fix (your suggestion, changing [[ to [). Thanks!

James Youngman <jay>
Project AdministratorIn charge of this item.
Sun 18 Apr 2010 10:56:04 AM UTC, original submission:

[[ -z "$DO_NOT_WANT_CHANGELOG_DRIVER" ]]

[[ tests ]] is a bash extension, therefore import-gnulib will not work reliably on systems where /bin/sh is dash instead of bash.

There are two ways to fix this:
a) I am /pretty/ sure that all instances of using [[ tests ]] in the script of could simply replaced with [ tests ].

b) Document it. Change the shebang line to /bin/bash and say "bash import-gnulib.sh" in README-hacking.

Andreas Metzler <ametzler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jay (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 May 2011 08:19:09 AM UTCjayOpen/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.5.9
    Sun 18 Apr 2010 11:55:39 AM UTCjaySeverity3 - Normal=>2 - Minor
      Item GroupNone=>Compilation Failure
      StatusNone=>Fixed
      Assigned toNone=>jay
    Sun 18 Apr 2010 10:56:13 AM UTCametzlerCarbon-CopyRemoved 20807=>-

    Back to the top


    Powered by Savane 3.1-cleanup1