bugCompact Disc Input and Control Library - Bugs: bug #29308, current git breaks when rock...

 
 

bug #29308: current git breaks when rock support is disabled

Submitted by:  Mike Frysinger <vapier>
Submitted on:  Mon 22 Mar 2010 11:49:54 PM UTC  
 
Category: NoneSeverity: 5 - Average
Item Group: libiso9660Status: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 23 Mar 2010 08:42:34 PM UTC, comment #2:

yep, works for me now, thanks

Mike Frysinger <vapier>
Tue 23 Mar 2010 08:32:24 PM UTC, comment #1:

Your suggested change has been applied. Please double check. Thanks.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Mon 22 Mar 2010 11:49:54 PM UTC, original submission:

lib/iso9660/iso9660.c unconditionally uses iso9660_get_posix_filemode_from_rock() in the function iso9660_get_posix_filemode(), but this is only provided when ROCK support is enabled (see Makefile.am).

this can be seen in the link failures like:
../lib/iso9660/.libs/libiso9660.so: undefined reference to `iso9660_get_posix_filemode_from_rock'
collect2: ld returned 1 exit status
make: *** [cd-info] Error 1

simple fix is probably something like:
--- a/lib/iso9660/iso9660.c
+++ b/lib/iso9660/iso9660.c
@@ -835,9 +835,12 @@
{
mode_t mode = 0;

+#ifdef HAVE_ROCK
if (yep == p_iso_dirent->rr.b3_rock) {
return iso9660_get_posix_filemode_from_rock(&p_iso_dirent->rr);
- } else if (p_iso_dirent->b_xa) {
+ } else
+#endif
+ if (p_iso_dirent->b_xa) {
return iso9660_get_posix_filemode_from_xa(p_iso_dirent->xa.attributes);
}
return mode;

Mike Frysinger <vapier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by vapier (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 23 Mar 2010 08:32:24 PM UTCrockyItem GroupNone=>libiso9660
      StatusNone=>Fixed
      Assigned toNone=>rocky
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1