bugGNU MyServer - Bugs: bug #29290, configure.ac does only check for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29290: configure.ac does only check for libevent symbols, but not for event.h

Submitted by:  Stephan Peijnik <sp>
Submitted on:  Sun 21 Mar 2010 09:11:33 PM UTC  
 
Severity: 3 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Giuseppe Scrivano <gscrivano>Open/Closed: Closed

Thu 25 Mar 2010 12:24:03 PM UTC, comment #3:

I am going to commit this patch:

From 970dc54701b4435a3b01f7cb895214bd09118d70 Mon Sep 17 00:00:00 2001
From: Stephan Peijnik <speijnik@gmail.com>
Date: Thu, 25 Mar 2010 13:21:59 +0100
Subject: [PATCH] Added missing check for event.h header in configure.ac

---
myserver/configure.ac | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/myserver/configure.ac b/myserver/configure.ac
index b12c2aa..336196e 100644
--- a/myserver/configure.ac
+++ b/myserver/configure.ac
@@ -155,9 +155,12 @@ else
fi
AC_SUBST(XNET_LIB)

+
AC_SEARCH_LIBS([event_add], [event event_core event_extra],,
[AC_MSG_ERROR([*** Cannot find libevent
*** libevent is required for MyServer])])
+AC_CHECK_HEADER([event.h],,[AC_MSG_ERROR([*** Cannnot find libevent header
+ *** libevent is required for MyServer])])

AC_CHECK_FUNCS(event_loopbreak,
AC_DEFINE(EVENT_LOOPBREAK, 1,
--
1.7.0.3

Giuseppe Scrivano <gscrivano>
Project AdministratorIn charge of this item.
Thu 25 Mar 2010 11:33:44 AM UTC, comment #2:

Sorry, I forgot to include the files in my last commit. Should be there now, commit d6c7526bf96601df539ad1961e7e465e8af33e0b, same repository.

Stephan Peijnik <sp>
Mon 22 Mar 2010 11:04:30 PM UTC, comment #1:

sorry but I can't see any change to configure.ac in your repository.

The only change I see in 1f24566521a7b2f0100e56a90c62a05da8c8213a is the .gitignore file.

Giuseppe Scrivano <gscrivano>
Project AdministratorIn charge of this item.
Sun 21 Mar 2010 09:11:33 PM UTC, original submission:

configure.ac should also check for event.h, because MyServer uses struct event. libevent could be present, but event.h not.

A patch is available from my git repository at http://github.com/speijnik/myserver

Stephan Peijnik <sp>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gscrivano (Posted a comment)
  • -unavailable- added by sp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 20 Apr 2010 04:16:39 PM UTCgscrivanoOpen/ClosedOpen=>Closed
    Thu 25 Mar 2010 12:24:03 PM UTCgscrivanoStatusIn Progress=>Fixed
    Mon 22 Mar 2010 11:04:54 PM UTCgscrivanoStatusNone=>In Progress
      Assigned toNone=>gscrivano

    Back to the top


    Powered by Savane 3.1-cleanup1