bugMIT/GNU Scheme - Bugs: bug #29288, .note.GNU-stack ELF section...

 
 

bug #29288: .note.GNU-stack ELF section missing from cmpauxmd.o

Submitted by:  William Throwe <wthrowe>
Submitted on:  Sun 21 Mar 2010 08:40:00 PM UTC  
 
Category: microcodeSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Taylor R. Campbell <riastradh>Originator Name: 
Open/Closed: Closed
Keywords: 

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 17 Apr 2010 09:13:54 PM UTC, comment #2:

Looks good to me. Just built the git sources and got no execute bit on the stack.

The m4 conditionals are probably a better way to go. I only used cpp because I don't know m4.

William Throwe <wthrowe>
Sat 17 Apr 2010 06:23:20 AM UTC, comment #1:

Sorry for responding to this so late. Commit a24dc2c558df3e3b67e15adf02e4fcc2e0c9ce9d attempts to address this on i386 and x86-64, using m4 conditionals rather than cpp conditionals. Let me know if this works for you -- cursory tests suggests that it does for me.

Taylor R. Campbell <riastradh>
Project MemberIn charge of this item.
Sun 21 Mar 2010 08:40:00 PM UTC, original submission:

The hand-crafted assembly code used to generate cmpauxmd.o does not specify a .note.GNU-stack section, leading to a scheme binary with executable stack. Executable stack does not seem to be needed for proper functioning of the binary.

I'm attaching a patch against version 9.0.1 for x86-64. I haven't tried to address other architectures, but I assume they would have similar fixes. The main change is adding a few lines at the end of x86-64.m4 and then preprocessing the assembly code.

William Throwe <wthrowe>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19998:  05_amd64_gnu-stack.patch added by wthrowe (1KiB - application/octet-stream - patch for x86-64)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by riastradh (Posted a comment)
  • -unavailable- added by wthrowe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 17 Apr 2010 09:15:36 PM UTCriastradhStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 17 Apr 2010 06:23:20 AM UTCriastradhStatusNone=>Ready For Test
      Assigned toNone=>riastradh
    Sun 21 Mar 2010 08:40:00 PM UTCwthroweAttached File-=>Added 05_amd64_gnu-stack.patch, #19998

    Back to the top


    Powered by Savane 3.1-cleanup1