bugGNU GRUB - Bugs: bug #29007, "error: unknown command...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29007: "error: unknown command `terminal'" if terminal_output gfxterm is false

Submitted by:  Colin Watson <cjwatson>
Submitted on:  Thu 25 Feb 2010 02:59:40 PM UTC  
 
Category: ConfigurationSeverity: Ordinary
Priority: 5 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Vladimir Serbinenko <phcoder>Originator Name: Colin King
Open/Closed: ClosedRelease: 
Release: Bazaar - trunkReproducibility: None
Planned Release: None

Mon 02 Aug 2010 06:47:56 PM UTC, comment #1:

2010-07-20 Vladimir Serbinenko <phcoder@gmail.com>

* util/grub.d/00_header.in: Remove compatibility with terminal.mod
prior to terminal_input/terminal_output separation. It's been over 1.5
years and those versions weren't widely deployed.

Colin Watson <cjwatson>
Project Member
Thu 25 Feb 2010 02:59:40 PM UTC, original submission:

In https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/519358, Colin King reports:

grub2 on an EFI firmware based machine reports the error message: "error: uknown command `terminal'".

I believe this occurs because "terminal_output gfxterm" fails to initialise (because we cannot probe or set the graphics mode) and then grub2 falls back to trying to be backwardly compatible with terminal.mod that does not support terminal_output by executing the non-existent command "terminal gfxterm".

The offending code is:

if terminal_output gfxterm ; then true ; else
# For backward compatibility with versions of terminal.mod that don't
# understand terminal_output
terminal gfxterm
fi

A possible workaround that stops the error message is:

if terminal_output gfxterm ; then true ; else
# For backward compatibility with versions of terminal.mod that don't
# understand terminal_output
if terminal gfxterm ; then
true
fi
fi

This seems to fix the problem on an EFI firmware based PC. I hope this does not break the backward compatibility terminal.mod workaround too.

Colin Watson <cjwatson>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cjwatson (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 02 Aug 2010 06:47:56 PM UTCcjwatsonStatusNone=>Fixed
      Assigned toNone=>phcoder
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1