bugGnash - The GNU Flash player - Bugs: bug #28911, plugin/Makefile.in: BOOST_CFLAGS...

 
 

bug #28911: plugin/Makefile.in: BOOST_CFLAGS not used

Submitted by:  None
Submitted on:  Tue 16 Feb 2010 11:34:42 AM UTC  
 
Category: buildSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Hicham HAOUARI <hichamhaouari>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Mar 2011 06:41:58 PM UTC, comment #1:

Done in 491ca6c758cdf5c84317569a1740b34f80db6af7.

Bastiaan Jacques <bjacques>
Project Member
Tue 16 Feb 2010 11:34:42 AM UTC, original submission:

hello,

apologies if I am missing some blatant point.

I found this with gnash-0.8.7 (was absent in 0.8.6)

I build with --with-boost-incl=/usr/include/boost

This is correctly set in plugin/Makefile:

BOOST_CFLAGS = -I/usr/include/boost

but then, apparently, BOOST_CFLAGS is ignored in the definition of LTCXXCOMPILE, which causes the build to crash with:

../libbase/StringPredicates.h:25:46: error: boost/algorithm/string/compare.hpp: No such file or directory
../libbase/StringPredicates.h:26:48: error: boost/algorithm/string/predicate.hpp: No such file or directory

As a matter of fact, this workaround:

diff -c plugin/Makefile.in.ORIG plugin/Makefile.in

      • plugin/Makefile.in.ORIG Tue Feb 16 11:44:33 2010

--- plugin/Makefile.in Tue Feb 16 11:44:33 2010
***************

      • 136,142 ****

$(CXXFLAGS) $(libgnashplugin_la_LDFLAGS) $(LDFLAGS) -o $@
@NPAPI_TRUE@@WIN32_FALSE@am_libgnashplugin_la_rpath = -rpath \
@NPAPI_TRUE@@WIN32_FALSE@ $(plugindir)
! DEFAULT_INCLUDES = -I.@am__isrc@ -I$(top_builddir)
depcomp = $(SHELL) $(top_srcdir)/depcomp
am__depfiles_maybe = depfiles
am__mv = mv -f
--- 136,142 ----
$(CXXFLAGS) $(libgnashplugin_la_LDFLAGS) $(LDFLAGS) -o $@
@NPAPI_TRUE@@WIN32_FALSE@am_libgnashplugin_la_rpath = -rpath \
@NPAPI_TRUE@@WIN32_FALSE@ $(plugindir)
! DEFAULT_INCLUDES = $(BOOST_CFLAGS) -I.@am__isrc@ -I$(top_builddir)
depcomp = $(SHELL) $(top_srcdir)/depcomp
am__depfiles_maybe = depfiles
am__mv = mv -f

fixes the problem for me.

I am on GNU/linux.

Thanks for your valuable work
ciao
gabriele

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19718:  mom.patch added by None (842B - application/octet-stream - oops, just seen that the diff is rendered incorrectly in the report window: this should be fine)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Mar 2011 06:41:58 PM UTCbjacquesStatusNone=>Fixed
      Assigned togg0=>hichamhaouari
      Open/ClosedOpen=>Closed
    Sun 13 Mar 2011 02:24:12 PM UTCbjacquesCategoryNone=>build
      Assigned toNone=>gg0
    Tue 16 Feb 2010 11:38:28 AM UTCNoneAttached File-=>Added mom.patch, #19718

    Back to the top


    Powered by Savane 3.1-cleanup1