bugGNUstep - Bugs: bug #28910, Actions can be invoked for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #28910: Actions can be invoked for GSWHTMLBareString by using GSWComponentContent

Submitted by:  Sergei Golovin <svg>
Submitted on:  Tue 16 Feb 2010 10:27:46 AM UTC  
 
Category: gswebSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Fri 30 Apr 2010 06:01:18 PM UTC, comment #1:

fixed in revision 30265

David Wetzel <dwetzel>
Project Member
Tue 16 Feb 2010 10:27:46 AM UTC, original submission:

GSWHTMLBareString raises an exception in the method

<-----------------------------------------------------------

-(GSWElement)invokeActionForRequest:(GSWRequest)request
inContext:(GSWContext*)context;

----------------------------------------------------------->

This is ok because actions make no sense for HTML strings. As a general rule GSWeb prevents from calling that method except from GSWComponentContent. Here is where the bug sits:

<-----------------------------------------------------------

component=GSWContext_component(aContext);
childTemplate=[component _childTemplate];
parent=[component parent];
[aContext _setCurrentComponent:parent];
element=[childTemplate invokeActionForRequest:request
inContext:aContext];

----------------------------------------------------------->

GSWComponentContent calls the method without any checking for the child template which can be GSWHTMLBareString.

There could be some checking on child template's class to avoid invoking and raising an exception when the class is GSWHTMLBareString. See the proposed patch.

Sergei Golovin <svg>

 

Attached Files
file #19716:  GSWComponentContent.patch added by svg (2KiB - text/x-patch - The patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dwetzel (Posted a comment)
  • -unavailable- added by svg (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 30 Apr 2010 06:01:18 PM UTCdwetzelStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 16 Feb 2010 10:27:46 AM UTCsvgAttached File-=>Added GSWComponentContent.patch, #19716

    Back to the top


    Powered by Savane 3.1-cleanup1