bugmake - Bugs: bug #2846, Fix for bug 2169 can cause endless...

 
 

bug #2846: Fix for bug 2169 can cause endless looping

Submitted by:  Invalid User ID <Invalid User ID>
Submitted on:  Mon 17 Mar 2003 10:31:16 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 3.80Operating System: Any
Fixed Release: 3.81Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 24 Mar 2003 11:21:06 PM UTC, comment #2:

OK, I've made a change to ENULLLOOP() to handle this.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Mon 17 Mar 2003 03:45:58 PM UTC, comment #1:

Hm. When a call fails it will set errno to indicate the error (if it's documented to use errno at all of course).

The macro only checks errno if the call failed.

Thus, no check of errno should ever encounter values left over from a previous failed call: the current failed call will overwrite whatever value it had previously with the current error.

Looking at the docs I see that this is not always true of ENULLLOOP; in particular I see that readdir() returns NULL but does not set errno when it reaches the end of the directory. I'll fix this, thanks.

I have nothing against making E*LOOP a no-op on systems with a working SA_RESTART, but I have no idea how to verify with autoconf whether a system has a working SA_RESTART or not. We would have to list systems where it does work (Linux for example) by hand. If SA_RESTART does work then the only thing we're losing is an extra comparison in the failure case, so it might not be worth it.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 01 Apr 2006 07:05:10 AM UTCpsmithFixed Release4.0=>3.81
Mon 24 Mar 2003 11:21:06 PM UTCpsmithStatusNone=>(Error - Not Found)
  Assigned toNone=>NA
  Open/ClosedOpen=>(Error - Not Found)
  Fixed ReleaseNone=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1