bugGNUstep - Bugs: bug #28415, crash with reoping an image with...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #28415: crash with reoping an image with PRICE

Submitted by:  Riccardo Mottola <rmottola>
Submitted on:  Sat 26 Dec 2009 11:32:07 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: NoneStatus: Invalid
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Declined

(Jump to the original submission Jump to the original submission)

Wed 06 May 2015 01:27:12 PM UTC, comment #6:

Your note is last: you are worried that there was as bug in GNUstep. The code in PRICE was proven to be buggy, but you had concerns in NIB/GORM loading

Riccardo Mottola <rmottola>
Project Member
Wed 06 May 2015 11:52:19 AM UTC, comment #5:

It this a PRICE bug or a GNUstep bug? Please see Fred's note below. Have you addressed the issues he mentions there?

Gregory John Casamento <gcasa>
Project Administrator
Thu 31 Dec 2009 06:36:37 PM UTC, comment #4:

Let me clarify... while I agree there are bugs in the PRWindowController code, I'm concerned that there may be some issues with when and how we're sending notifications to NSWindow.

Also, further research indicates that there is NOT an extra retain in the nib loading code. This would occur in nibInstantiate in NSWindowController. I put an AUTORELEASE in there and the NSWindow was immediately release/closed when a new document was loaded (thus causing the nib to load).

Gregory John Casamento <gcasa>
Project Administrator
Thu 31 Dec 2009 06:17:24 PM UTC, comment #3:

When converting the nib to a gorm file, it also crashes.

I'm wondering if the problem might not be somewhere else aside from nib/gorm loading. Why, exactly, are we getting a notification event for an object which has already been released/dealloc'd?

GC

Gregory John Casamento <gcasa>
Project Administrator
Thu 31 Dec 2009 05:59:33 PM UTC, comment #2:

I tried two possible solutions:
1) remove the notification as suggested. This fixes the crash
2) do not use the PRWindowController window outlet, but the one from NSWindowController. That works too.

Of course, both 1) and 2) are improvements to the PRICE code.
What worries me here is consistency between NIB loading ad GORM loading.

Riccardo Mottola <rmottola>
Project Member
Tue 29 Dec 2009 01:06:24 PM UTC, comment #1:

This problem is caused by multiple bugs in the source code of PRWindowController. The method windowDidLoad registers for NSNotifications on NSWindowDidResizeNotification. As the object to watch for the instance variable window is used. This seems only to be set for NIB loading and it shouldn't exist at all. This results in the window controller responding to all window resize events, also the window controller is retained by the notification center and wont go away when the window is released. That way when a new window is loaded the notification center calls the _windowDidResize method of the window controller and this will crash, as the view is long gone.
The controller should register for the correct window and remove this connection again, when the window is removed.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sat 26 Dec 2009 11:32:07 PM UTC, original submission:

using gnustep, latest PRICE.

I can open an image, close it. Repoen the same image, PRICE will crash with a memory allocation error.

The same code works on the mac. So either gui is releasing something differently or the gorm file is not equivalent to the nib file.
Using the NIB file as test hoewever is not conclusive until the bug about styleMask flags is not fixed because apparently they are not decoded correctly.

Riccardo Mottola <rmottola>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gcasa (Posted a comment)
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by rmottola (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 05 May 2015 07:47:04 PM UTCrmottolaStatusNone=>Invalid
      Open/ClosedAnalyzed=>Declined
    Tue 05 May 2015 07:46:00 PM UTCrmottolaStatusInvalid=>None
      Open/ClosedDeclined=>Analyzed
    Tue 29 Dec 2009 01:06:24 PM UTCFredKieferStatusNone=>Invalid
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>Declined

    Back to the top


    Powered by Savane 3.1-cleanup1