bugGnash - The GNU Flash player - Bugs: bug #28269, import symbol bug (SWF6)

 
 

bug #28269: import symbol bug (SWF6)

Submitted by:  Sandro Santilli <strk>
Submitted on:  Sat 12 Dec 2009 09:23:48 AM UTC  
 
Category: coreSeverity: 5 - Blocker
Release: trunkStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 12 Dec 2009 11:14:39 AM UTC, comment #5:

r11689 also adds the double import thing.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 12 Dec 2009 11:06:11 AM UTC, comment #4:

Test automated as of r11688.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 12 Dec 2009 10:09:59 AM UTC, comment #3:

Fixed in r11687.

TODO: automate testing of this !!

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 12 Dec 2009 10:02:26 AM UTC, comment #2:

Alright, I made another test which imports the 'redsquare' symbol from attachMovieTest.swf, and the result is that the symbol IS FOUND so my patch is fine there.
Remember that attachMovieTest.swf doesn't export 'redsquare' itself but imports it from sym.swf so the chain is fully scanned.

Duplicating the export in the importing movie seems good enough for this.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 12 Dec 2009 09:53:32 AM UTC, comment #1:

Luckly this was a simple one. Basically when a movie IMPORTs symbols, it currently doesn't advertise them as exported.

attachMovie queries the movie for exported symbols and doesn't
find them (cause the get_exported_resources function doesn't check
in the set of imported ones).

I patched the code so that any imported symbol is automatically
exported. Might be not elegant or efficient or compatible (thinking cross scripting security) but works for me and doesn't
break any testcase.

Would be useful to have this case automatically tested
(only affects movies with IMPORT tag)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 12 Dec 2009 09:23:48 AM UTC, original submission:

While trying to produce a testcase to figure out where
the most memory goes in the potlatch/photo case I stubled
upon a bug in importing symbols from external movies.

The attached tarball contains a sym.swf with a symbol in it (redsquare) and an attachMovieTest.swf looping and attaching
the imported symbol. The source of the latter is in attachMovieTest.as, which needs to be compiled using the -isym.swf:redsquare switch to makeswf.

If you run the movie with the pp you see the imported red
square character appearing (once for loop itaration, 5000 iteration but you can change that in the as file).

If you run the movie with gnash you'll get errors about the
fact gnash can NOT find the symbol.

Could be a regression.

Sandro Santilli <strk>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19241:  attachImportedSymbol.tgz added by strk (9KiB - application/x-compressed-tar)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 12 Dec 2009 11:14:39 AM UTCstrkOpen/ClosedOpen=>Closed
    Sat 12 Dec 2009 11:06:11 AM UTCstrkStatusReady For Test=>Fixed
    Sat 12 Dec 2009 10:09:59 AM UTCstrkStatusIn Progress=>Ready For Test
    Sat 12 Dec 2009 09:53:32 AM UTCstrkStatusNone=>In Progress
      Assigned toNone=>strk
    Sat 12 Dec 2009 09:23:49 AM UTCstrkAttached File-=>Added attachImportedSymbol.tgz, #19241

    Back to the top


    Powered by Savane 3.1-cleanup1