bugMIT/GNU Scheme - Bugs: bug #27887, i386 assembly hook for generic...

 
 

bug #27887: i386 assembly hook for generic multiplication multiplies fixnums incorrectly

Submitted by:  Taylor R. Campbell <riastradh>
Submitted on:  Fri 30 Oct 2009 09:24:55 PM UTC  
 
Category: microcodeSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Incorrect behavior
Status: FixedPrivacy: Public
Assigned to: Taylor R. Campbell <riastradh>Originator Name: 
Open/Closed: Closed
Keywords: 

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 12 Nov 2009 09:55:29 PM UTC, comment #1:

Fixed in commit 84b1f57fbe67265816dde2cec64786e09ddcf349.

Taylor R. Campbell <riastradh>
Project MemberIn charge of this item.
Fri 30 Oct 2009 09:24:55 PM UTC, original submission:

((fluid-let ((compiler:open-code-primitives? #f))
(compile-procedure
(eval `(LAMBDA (X Y) (,(make-primitive-procedure '&*) X Y))
(nearest-repl/environment))))
1
2)
;Value: 128

This is a reminder to me to commit the fix (shift EAX right by 6 before IMUL), once I have cleaned up a large number of other changes that it shouldn't get swept into.

(This doesn't really matter at all -- nobody ever inhibits open-coding of primitives, so that the fixnum case is always open-coded and the assembly hook's fixnum case is never used. So this bug has lain dormant for fifteen years.)

Taylor R. Campbell <riastradh>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by riastradh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 12 Nov 2009 09:55:29 PM UTCriastradhStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1