bugXBoard - Bugs: bug #27826, Tags and comment windows

 
 

bug #27826: Tags and comment windows

Submitted by:  None
Submitted on:  Tue 27 Oct 2009 02:56:05 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 28 Oct 2009 08:42:12 AM UTC, comment #5:

I can only test XBoard. All options work as expected with git 2b102a5aee6ecd7f801208d2c6f6aacf59397ee4.

Anonymous
Tue 27 Oct 2009 10:40:24 PM UTC, comment #4:

I think this must have not worked correctly in WinBoard either. (i.e. I broke it somewhere around 4.3.15, and no one ever complained!) I think I have given it a reasonable behavior now:

Default: -autoDisplayComment true
This pops up the comment window on any move that has a comment, also if it is a score/depth type comment made by an engine (of the type you get with -pgnExtendedInfo true).

-autoDisplayComment false
This does not popup the comment window, unless you explicitly request it through the menu item Mode -> Edit Comment. But once it is up, it will be refreshed with title and comment of a move that has a comment.

The title now is always the move (if there is one).

H.G. Muller

Anonymous
Tue 27 Oct 2009 10:33:13 PM UTC, comment #3:

uploaded a patch from HGM. Please test again

Arun Persaud <apersaud>
Project Administrator
Tue 27 Oct 2009 07:57:39 PM UTC, comment #2:

"-autoDisplayComment false" still opens titleless comment windows.

"-autoDisplayComment true" gives the correct window.

"-autoDisplayTags" works as expected.

Anonymous
Tue 27 Oct 2009 03:40:17 PM UTC, comment #1:

Good point!

In WinBoard (and thus the back-end) the popping up of tags and comment windows are now under control of the options -autoDisplayTags true/false and -autoDisplayComment true/false. But I see that those options were never ported to XBoard. I was not aware that 4.2.7 did not have these options, I thought they were primordial, but apparently they were introduced in WinBoard_x. There the default setting is "true", but this requires initialization (in winboard.c, which handles the options), as un-initialized memory is interpreted as "false". Which it thus what happens in XBoard.

The missing title is a consequence of that: when you pop up the window through the menu it is an edit window without a title. I belief this was also the case in 4.2.7 and WinBoard; the window title only appears on auto-popup.

The command-line options will of course have to be added, and I think their default settings should be true (as in WinBoard), to reproduce old behavior (no matter how irritating that was...). I will fix it.

H.G. Muller

Anonymous
Tue 27 Oct 2009 02:56:05 PM UTC, original submission:

2 minor observations, when loading a file with tags & comments.
1. In xboard 4.2.7 the "Tags" window opens right after loading. This doesn't happen with the new xboard.

2. When a commented move is reached, the Comment windows is opened. In 4.2.7 the window title showed "Comment on 15. exd5".
Now the title shows nothing.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by apersaud (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 29 Oct 2009 03:39:36 AM UTCapersaudOpen/ClosedOpen=>Closed
      StatusReady For Test=>Fixed
    Tue 27 Oct 2009 07:31:19 PM UTCapersaudStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1