bugXBoard - Bugs: bug #27790, Variant switch not detected

 
 

bug #27790: Variant switch not detected

Submitted by:  None
Submitted on:  Fri 23 Oct 2009 12:13:54 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 31 Oct 2009 09:23:23 AM UTC, comment #5:

The points mentioned in "original submission" & "comment #2" are working now.
I haven't tested the follow-up points mentioned in the commit messages regarding "Variant Switch"

Anonymous
Sat 31 Oct 2009 03:11:14 AM UTC, comment #4:

Is this completely fixed now?

Arun Persaud <apersaud>
Project Administrator
Sat 24 Oct 2009 01:38:35 PM UTC, comment #3:

OK, I think I fully understand how it works now. The new game starts with a board, but as the board oof FRC is not recognizably strange, you stay in VariantNormal. (That it is not the regular opening position is no clue, as there are many wilds with non-standard starting positions that are played as VariantNormal.) But then the move list is requested (even when the board was for move number 0), and triggers an offending VariantSwitch: normally VariantSwitch redraws the current board in the context of the new variant, after initializing the variant. The latter also sets up board 0, and in shuffle games triggers a re-shuffle there. This is unwanted, and later corrected when the board for the initial position comes in again with the move list. But the latter is never displayed, as movelists are supposed to be fetched in the background. So although it is setup in boards[0], it is neer displayed, and the wrong shuffle hangs in the display until a move occurs.

I will fix it by putting back the original board after initializing the new variant, when the board to display was boards[0], and thus must have contained the original shuffle.

H.G. Muller

Anonymous
Sat 24 Oct 2009 07:08:50 AM UTC, comment #2:

Tried that and the variant is recognized now. But as in that manual case I described, the initial board of the observer gets an extra shuffle in all wild variants. The position is repaired after white's first move, though.

Apropos FRC - there is another unguarded debug printf in parser.[lc]:

fprintf(debugFP, "Parser FRC long %d %d\n", ff, ft);

Anonymous
Fri 23 Oct 2009 08:20:06 PM UTC, comment #1:

It seems that when observing a game, one always has to fetch a move list to know which variant it was, even if you see the very first board. FICS gives an indication of the variant after saying "You are now observing game #.", but ICC doesn't, and immediately dumps a board on you. For games you play yourself this is not needed, as the "Creating ..." message before contains the variant indication.

Can you try changing line 3541 of backend.c:

} else if (moveNum > 0 && newGameMode != IcsIdle &&

to:

} else if ((moveNum > 0 || newGameMode == IcsObserving) && newGameMode != IcsIdle &&

? I think this should solve it.

H.G. Muller

Anonymous
Fri 23 Oct 2009 12:13:54 PM UTC, original submission:

When observing a FRC game on FICS right from move 1 (with follow or gnotify) xboard stays in variant normal. I suspected that xboard doesn't request a move list in that case. To verify that, I did a triple guest login at FICS. 2 player starting a FRC without moving. The 3rd observes (start position displayed correctly but variant=normal). After manually giving the "moves" command for the observer, xboard does switch to FRC but also shuffles the startposition.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by apersaud (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 07 Mar 2010 02:35:28 AM UTCapersaudStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 31 Oct 2009 03:11:14 AM UTCapersaudStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1